Re: [PATCH V2] I2C: Fix for suspend/resume issue in i2c-core

["Cousson, Benoit" <b-cousson-l0cyMroinI0@public.gmane.org>]

Hi Vishwa,

I just have a couple of minors comments:

On 9/4/2010 10:48 AM, Sripathy, Vishwanath wrote:
> In current i2c core driver, call to pm_runtime_set_active from i2c_device_pm_resume
> will unconditionally enable i2c module and increment child count of the parent.
> Because of this, in CPU Idle path, i2c does not idle, preventing Core to
> enter retention. Also i2c module will not be suspended upon system suspend as
> pm_runtime_set_suspended is not called from i2c_device_pm_suspend.
> This issue is fixed by  removing  pm_runtime_set_active call from resume path which
Unnecessary spaces: -----^ and ----^

> is not necessary.
> This fix has been tested on OMAP4430.
>
> Signed-off-by: Partha Basak<p-basak2-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Vishwanath BS<vishwanath.bs-l0cyMroinI0@public.gmane.org>
>
> Cc: Rafael J. Wysocki<rjw-KKrjLPT3xs0@public.gmane.org>
> Cc: Kevin Hilman<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
> Cc: Ben Dooks<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
> Cc: Jean Delvare<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> ---
>   drivers/i2c/i2c-core.c |    6 ------
>   1 files changed, 0 insertions(+), 6 deletions(-)
>   mode change 100644 =>  100755 drivers/i2c/i2c-core.c

You should probably not have to change the file mode.

Regards,
Benoit

>
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> old mode 100644
> new mode 100755
> index 6649176..13927d5
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -216,12 +216,6 @@ static int i2c_device_pm_resume(struct device *dev)
>   	else
>   		ret = i2c_legacy_resume(dev);
>
> -	if (!ret) {
> -		pm_runtime_disable(dev);
> -		pm_runtime_set_active(dev);
> -		pm_runtime_enable(dev);
> -	}
> -
>   	return ret;
>   }
>