From: Jiri Slaby <jirislaby@gmail.com>
To: lrg@slimlogic.co.uk
Cc: alsa-devel@alsa-project.org, LKML <linux-kernel@vger.kernel.org>
Subject: tlv320aic3x: potential null dereference
Date: Sat, 04 Sep 2010 15:07:57 +0200 [thread overview]
Message-ID: <4C8244AD.6090900@gmail.com> (raw)
Hi,
stanse found a potential null dereference:
aic3x_i2c_probe
-> struct aic3x_setup_data *setup = pdata->setup;
-> -- pdata can't be null now--
-> if (pdata && pdata->gpio_reset >= 0)
But there is another check for pdata == NULL. Could take a look and fix
it (either remove the check or move the assignement inside the if)?
thanks,
--
js
next reply other threads:[~2010-09-04 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 13:07 Jiri Slaby [this message]
2010-09-05 15:46 ` tlv320aic3x: potential null dereference Jarkko Nikula
2010-09-05 15:46 ` [alsa-devel] " Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8244AD.6090900@gmail.com \
--to=jirislaby@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.