Re: [PATCH] LED control

[Hans de Goede <hdegoede@redhat.com>]

Hi all,

On 09/04/2010 01:10 PM, Jean-Francois Moine wrote:
> Some media devices may have one or many lights (LEDs, illuminators,
> lamps..). This patch makes them controlable by the applications.
>
> Signed-off-by: Jean-Francois Moine<moinejf@free.fr>
>
> -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
>
>
> led.patch
>
>
> diff --git a/Documentation/DocBook/v4l/controls.xml b/Documentation/DocBook/v4l/controls.xml
> index 8408caa..c9b8ca5 100644
> --- a/Documentation/DocBook/v4l/controls.xml
> +++ b/Documentation/DocBook/v4l/controls.xml
> @@ -312,6 +312,13 @@ minimum value disables backlight compensation.</entry>
>   	information and bits 24-31 must be zero.</entry>
>   	</row>
>   	<row>
> +	<entry><constant>V4L2_CID_LEDS</constant></entry>
> +	<entry>integer</entry>
> +	<entry>Switch on or off the LED(s) or illuminator(s) of the device.
> +	    The control type and values depend on the driver and may be either
> +	    a single boolean (0: off, 1:on) or the index in a menu type.</entry>
> +	</row>

I think that using one control for both status leds (which is what we are usually
talking about) and illuminator(s) is a bad idea. I'm fine with standardizing these,
but can we please have 2 CID's one for status lights and one for the led. Esp, as I
can easily see us supporting a microscope in the future where the microscope itself
or other devices with the same bridge will have a status led, so then we will need
2 separate controls anyways.

Regards,

Hans