Re: KVM: x86: set vcpu runnable when injecting MCE

[Avi Kivity <avi@redhat.com>]

  On 09/03/2010 02:41 AM, Marcelo Tosatti wrote:
> Otherwise an MCE exception to a halted vcpu is only injected when
> vcpu is awakened due to unrelated event.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 4014d6c..86127e8 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -2399,6 +2399,7 @@ static int kvm_vcpu_ioctl_x86_set_mce(struct kvm_vcpu *vcpu,
>   		vcpu->arch.mcg_status = mce->mcg_status;
>   		banks[1] = mce->status;
>   		kvm_queue_exception(vcpu, MC_VECTOR);
> +		vcpu->arch.mp_state = KVM_MP_STATE_RUNNABLE;

What happens if the vcpu is in KVM_MP_STATE_UNINITIALIZED?

I guess we just don't care?

-- 
error compiling committee.c: too many arguments to function