On 09/05/2010 11:44 AM, BVK Chaitanya wrote:
> +
> +  if (invert)
> +    ret = ! ret;
>  
>   
You need either to create grub_errno or to handle it. So it should be like:
if (invert)
{
   if (ret == GRUB_ERR_TEST_FAILURE)
       grub_errno = ret = GRUB_ERR_NONE;
   else if (ret == GRUB_ERR_NONE)
       ret = grub_error (GRUB_ERR_TEST_FAILURE, "false");
   else
       {
            grub_print_error ();
            ret = GRUB_ERR_NONE;
       }
}
Other than that, patch is fine

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko