From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OsHBO-0005dl-Bk for mharc-grub-devel@gnu.org; Sun, 05 Sep 2010 11:31:02 -0400 Received: from [140.186.70.92] (port=33548 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OsHBL-0005b1-Kw for grub-devel@gnu.org; Sun, 05 Sep 2010 11:31:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OsHBK-0005sn-MU for grub-devel@gnu.org; Sun, 05 Sep 2010 11:30:59 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:41157) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OsHBK-0005sh-I9 for grub-devel@gnu.org; Sun, 05 Sep 2010 11:30:58 -0400 Received: by eyh5 with SMTP id 5so2114001eyh.0 for ; Sun, 05 Sep 2010 08:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=ZXnSYfPRvPKB/b93SbxpmFO25RJLHPHxoU5cVg6vOFM=; b=AMdHPdsBCwSwrR40F1CEPlHcuZ0m8Ob7Rvs30pSzeLFZL5nUdqVNkvkgv72pke9bVi PYkSD6FR4W18AEmIr0ogzkgq6bfdMpIDVqr8ldaCp7BVOfeQxDSq87hk8B5Sro/xSgwK gfbh4WbrFZZzgiq/NsEZHXQN0CzSxld+ETqUQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=V+f5J6rK614WIshENLpBy9fL9t7Vi+VQW/fDj5TeZUjRa7Dx6JoGYasGQdjzsxiYj3 7kMIe3QG2d3PqjHMxcbtwsG9n22dTC+ynilITZG874R0yojAlUcoyhIwixXlHTViQG/f r24IVOk/estdKYBy0cTu1a+hmMTYV3GnUYZ+o= Received: by 10.213.48.131 with SMTP id r3mr1595308ebf.69.1283700657666; Sun, 05 Sep 2010 08:30:57 -0700 (PDT) Received: from debian.bg45.phnet (124.117.63.81.cust.bluewin.ch [81.63.117.124]) by mx.google.com with ESMTPS id z55sm6461525eeh.15.2010.09.05.08.30.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 05 Sep 2010 08:30:56 -0700 (PDT) Message-ID: <4C83B7A8.4070908@gmail.com> Date: Sun, 05 Sep 2010 17:30:48 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Icedove/3.0.6 MIME-Version: 1.0 To: grub-devel@gnu.org References: In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8892C7F4AEBE4D4DD27065D7" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Not command (!) support for GRUB script X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Sep 2010 15:31:00 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8892C7F4AEBE4D4DD27065D7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/05/2010 11:44 AM, BVK Chaitanya wrote: > + > + if (invert) > + ret =3D ! ret; > =20 > =20 You need either to create grub_errno or to handle it. So it should be lik= e: if (invert) { if (ret =3D=3D GRUB_ERR_TEST_FAILURE) grub_errno =3D ret =3D GRUB_ERR_NONE; else if (ret =3D=3D GRUB_ERR_NONE) ret =3D grub_error (GRUB_ERR_TEST_FAILURE, "false"); else { grub_print_error (); ret =3D GRUB_ERR_NONE; } } Other than that, patch is fine --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig8892C7F4AEBE4D4DD27065D7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkyDt6gACgkQNak7dOguQgmWfgD9E4pqhzQzK4X4zz9ttPVXE6nu MFlAojoHr4Sx0l41ZiABAMRK8uLa3Wby1wOnVp32XxBIlFq2JCn4IBaVsVXwOKVI =U3mf -----END PGP SIGNATURE----- --------------enig8892C7F4AEBE4D4DD27065D7--