All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: SCSI development list <linux-scsi@vger.kernel.org>,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: libata: SATL error processing: unrecovered read error
Date: Sun, 05 Sep 2010 11:57:16 -0400	[thread overview]
Message-ID: <4C83BDDC.3020201@interlog.com> (raw)

While looking at an eSATA connected external disk with
a medium error, this sense data appeared:

     READ cdb: 28 00 96 4a 7a d1 00 00 01 00
       duration=2816 ms
READ:  Descriptor format, current;  Sense key: Medium Error
  Additional sense: Unrecovered read error - auto reallocate failed
   Descriptor type: Information
     0x00000000964a7ad1
  Raw sense data (in hex):
         72 03 11 04 00 00 00 0c  00 0a 80 00 00 00 00 00
         96 4a 7a d1

That is pretty close to what I was expecting to see. If anything
there is too much information. That "Unrecovered read error -
auto reallocate failed" [asc/asq: 11h/04h] should just be
"Unrecovered read error" [asc/asq: 11h/0h]. See sat2r09.pdf table
105 or sat3r00.pdf table 105.

The problem seems to be in libata's SATL code in the sense_table[]
in ata_to_sense_error() in libata-scsi.c . Looks like some other
entries in that sense_table need adjusting as well to align them
to SAT's table 105.

Also it is good to have a reference comment as sense_data[]
does in lk 2.6.35:
   /* Based on the 3ware driver translation table */

but this would be better (if it did comply):
   /* Based on table 105 in SAT-2 rev 9 */

Doug Gilbert

             reply	other threads:[~2010-09-05 15:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-05 15:57 Douglas Gilbert [this message]
2010-09-17 18:31 ` libata: SATL error processing: unrecovered read error Jeff Garzik
2010-09-17 19:26   ` Douglas Gilbert
2010-09-17 19:32     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C83BDDC.3020201@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.