All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Johansen <john.johansen@canonical.com>
To: James Morris <jmorris@namei.org>
Cc: Jiri Slaby <jirislaby@gmail.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: apparmor: double lock
Date: Mon, 06 Sep 2010 10:13:12 -0700	[thread overview]
Message-ID: <4C852128.3040708@canonical.com> (raw)
In-Reply-To: <alpine.LRH.2.00.1009061029170.9229@tundra.namei.org>

On 09/05/2010 05:29 PM, James Morris wrote:
> On Sat, 4 Sep 2010, John Johansen wrote:
> 
>> On 09/04/2010 04:57 AM, Jiri Slaby wrote:
>>> Hi,
>>>
>>> stanse found that you possibly double lock ns->lock:
>>> aa_remove_profiles
>>>   -> write_lock(&ns->lock)
>>>   -> __remove_namespace(ns)
>>>     -> destroy_namespace(ns)
>>>       -> write_lock(&ns->lock)
>>>
>>> Could you fix that if that may happen at all?
>>>
>> Yes, thanks Jiri, the patch has already been posted
>>
>> http://marc.info/?l=linux-kernel&m=128295924407596&w=2
> 
> Are all of the patches in that set ready to be merged to Linus?
> 
yes they should be now, I believe so.

I have just posted out the updated  Fix security_task_setrlimit logic
patch that fixes the commenting.  I can repost the series if you would
like.

thanks
john

      reply	other threads:[~2010-09-06 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-04 11:57 apparmor: double lock Jiri Slaby
2010-09-05  5:41 ` John Johansen
2010-09-06  0:29   ` James Morris
2010-09-06 17:13     ` John Johansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C852128.3040708@canonical.com \
    --to=john.johansen@canonical.com \
    --cc=jirislaby@gmail.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.