* [PATCH] libsdl-native: Convert to new style staging, remove do_stage
@ 2010-09-06 12:19 Noor Ahsan
2010-09-06 12:34 ` Frans Meulenbroeks
2010-09-06 23:27 ` Graham Gower
0 siblings, 2 replies; 6+ messages in thread
From: Noor Ahsan @ 2010-09-06 12:19 UTC (permalink / raw)
To: openembedded-devel
* Remove do_stage ()
* Replace tabs with 8 spaces in do_configure
* Bump INC_PR = "r3"
Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
---
recipes/libsdl/libsdl-native.inc | 18 +++++++-----------
1 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/recipes/libsdl/libsdl-native.inc b/recipes/libsdl/libsdl-native.inc
index 783797a..faae90c 100644
--- a/recipes/libsdl/libsdl-native.inc
+++ b/recipes/libsdl/libsdl-native.inc
@@ -2,7 +2,7 @@ DESCRIPTION = "Simple DirectMedia Layer - native Edition"
HOMEPAGE = "http://www.libsdl.org"
SECTION = "libs"
LICENSE = "LGPL"
-INC_PR = "r2"
+INC_PR = "r3"
SRC_URI = "http://www.libsdl.org/release/SDL-${PV}.tar.gz \
"
@@ -23,15 +23,11 @@ EXTRA_OECONF = "--disable-debug --disable-cdrom --enable-threads --enable-timers
--disable-video-picogui --disable-video-qtopia --enable-dlopen"
do_configure() {
- gnu-configize
- oe_runconf
- cd ${S}
- # prevent libtool from linking libs against libstdc++, libgcc, ...
- cat ${TARGET_PREFIX}libtool | sed -e 's/postdeps=".*"/postdeps=""/' > ${TARGET_PREFIX}libtool.tmp
- mv ${TARGET_PREFIX}libtool.tmp ${TARGET_PREFIX}libtool
+ gnu-configize
+ oe_runconf
+ cd ${S}
+ # prevent libtool from linking libs against libstdc++, libgcc, ...
+ cat ${TARGET_PREFIX}libtool | sed -e 's/postdeps=".*"/postdeps=""/' > ${TARGET_PREFIX}libtool.tmp
+ mv ${TARGET_PREFIX}libtool.tmp ${TARGET_PREFIX}libtool
}
-do_stage() {
- autotools_stage_all
- install -m 0644 build/libSDLmain.a ${STAGING_LIBDIR}
-}
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] libsdl-native: Convert to new style staging, remove do_stage
2010-09-06 12:19 [PATCH] libsdl-native: Convert to new style staging, remove do_stage Noor Ahsan
@ 2010-09-06 12:34 ` Frans Meulenbroeks
2010-09-06 12:38 ` Ahsan, Noor
2010-09-06 23:27 ` Graham Gower
1 sibling, 1 reply; 6+ messages in thread
From: Frans Meulenbroeks @ 2010-09-06 12:34 UTC (permalink / raw)
To: openembedded-devel
2010/9/6 Noor Ahsan <noor_ahsan@mentor.com>:
> * Remove do_stage ()
> * Replace tabs with 8 spaces in do_configure
> * Bump INC_PR = "r3"
>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> ---
> recipes/libsdl/libsdl-native.inc | 18 +++++++-----------
> 1 files changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/recipes/libsdl/libsdl-native.inc b/recipes/libsdl/libsdl-native.inc
> index 783797a..faae90c 100644
> --- a/recipes/libsdl/libsdl-native.inc
> +++ b/recipes/libsdl/libsdl-native.inc
> @@ -2,7 +2,7 @@ DESCRIPTION = "Simple DirectMedia Layer - native Edition"
> HOMEPAGE = "http://www.libsdl.org"
> SECTION = "libs"
> LICENSE = "LGPL"
> -INC_PR = "r2"
> +INC_PR = "r3"
>
> SRC_URI = "http://www.libsdl.org/release/SDL-${PV}.tar.gz \
> "
> @@ -23,15 +23,11 @@ EXTRA_OECONF = "--disable-debug --disable-cdrom --enable-threads --enable-timers
> --disable-video-picogui --disable-video-qtopia --enable-dlopen"
>
> do_configure() {
> - gnu-configize
> - oe_runconf
> - cd ${S}
> - # prevent libtool from linking libs against libstdc++, libgcc, ...
> - cat ${TARGET_PREFIX}libtool | sed -e 's/postdeps=".*"/postdeps=""/' > ${TARGET_PREFIX}libtool.tmp
> - mv ${TARGET_PREFIX}libtool.tmp ${TARGET_PREFIX}libtool
> + gnu-configize
> + oe_runconf
> + cd ${S}
> + # prevent libtool from linking libs against libstdc++, libgcc, ...
> + cat ${TARGET_PREFIX}libtool | sed -e 's/postdeps=".*"/postdeps=""/' > ${TARGET_PREFIX}libtool.tmp
> + mv ${TARGET_PREFIX}libtool.tmp ${TARGET_PREFIX}libtool
> }
>
> -do_stage() {
> - autotools_stage_all
> - install -m 0644 build/libSDLmain.a ${STAGING_LIBDIR}
> -}
when you build is tlibSDLmain.a still moved to staging ?
Frans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libsdl-native: Convert to new style staging, remove do_stage
2010-09-06 12:34 ` Frans Meulenbroeks
@ 2010-09-06 12:38 ` Ahsan, Noor
0 siblings, 0 replies; 6+ messages in thread
From: Ahsan, Noor @ 2010-09-06 12:38 UTC (permalink / raw)
To: openembedded-devel
Yes. I checked the ipk file. There was no difference in lib dir.
-----Original Message-----
From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of Frans Meulenbroeks
Sent: Monday, September 06, 2010 5:35 PM
To: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH] libsdl-native: Convert to new style staging,remove do_stage
2010/9/6 Noor Ahsan <noor_ahsan@mentor.com>:
> * Remove do_stage ()
> * Replace tabs with 8 spaces in do_configure
> * Bump INC_PR = "r3"
>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> ---
> recipes/libsdl/libsdl-native.inc | 18 +++++++-----------
> 1 files changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/recipes/libsdl/libsdl-native.inc b/recipes/libsdl/libsdl-native.inc
> index 783797a..faae90c 100644
> --- a/recipes/libsdl/libsdl-native.inc
> +++ b/recipes/libsdl/libsdl-native.inc
> @@ -2,7 +2,7 @@ DESCRIPTION = "Simple DirectMedia Layer - native Edition"
> HOMEPAGE = "http://www.libsdl.org"
> SECTION = "libs"
> LICENSE = "LGPL"
> -INC_PR = "r2"
> +INC_PR = "r3"
>
> SRC_URI = "http://www.libsdl.org/release/SDL-${PV}.tar.gz \
> "
> @@ -23,15 +23,11 @@ EXTRA_OECONF = "--disable-debug --disable-cdrom --enable-threads --enable-timers
> --disable-video-picogui --disable-video-qtopia --enable-dlopen"
>
> do_configure() {
> - gnu-configize
> - oe_runconf
> - cd ${S}
> - # prevent libtool from linking libs against libstdc++, libgcc, ...
> - cat ${TARGET_PREFIX}libtool | sed -e 's/postdeps=".*"/postdeps=""/' > ${TARGET_PREFIX}libtool.tmp
> - mv ${TARGET_PREFIX}libtool.tmp ${TARGET_PREFIX}libtool
> + gnu-configize
> + oe_runconf
> + cd ${S}
> + # prevent libtool from linking libs against libstdc++, libgcc, ...
> + cat ${TARGET_PREFIX}libtool | sed -e 's/postdeps=".*"/postdeps=""/' > ${TARGET_PREFIX}libtool.tmp
> + mv ${TARGET_PREFIX}libtool.tmp ${TARGET_PREFIX}libtool
> }
>
> -do_stage() {
> - autotools_stage_all
> - install -m 0644 build/libSDLmain.a ${STAGING_LIBDIR}
> -}
when you build is tlibSDLmain.a still moved to staging ?
Frans
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libsdl-native: Convert to new style staging, remove do_stage
2010-09-06 12:19 [PATCH] libsdl-native: Convert to new style staging, remove do_stage Noor Ahsan
2010-09-06 12:34 ` Frans Meulenbroeks
@ 2010-09-06 23:27 ` Graham Gower
2010-09-07 6:32 ` Frans Meulenbroeks
1 sibling, 1 reply; 6+ messages in thread
From: Graham Gower @ 2010-09-06 23:27 UTC (permalink / raw)
To: openembedded-devel
On 6 September 2010 21:49, Noor Ahsan <noor_ahsan@mentor.com> wrote:
> * Remove do_stage ()
> * Replace tabs with 8 spaces in do_configure
I see that spaces and not tabs are the OE policy, but I can't lay my
eyes on anything that says how many spaces are preferred. I see a lot
of recipes and examples using 4 space indentation (and most others use
a tab). Is this something that people care about?
-Graham
PS: Personally I'm a tab man, not a spaceman.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libsdl-native: Convert to new style staging, remove do_stage
2010-09-06 23:27 ` Graham Gower
@ 2010-09-07 6:32 ` Frans Meulenbroeks
2010-09-07 6:32 ` Graeme Gregory
0 siblings, 1 reply; 6+ messages in thread
From: Frans Meulenbroeks @ 2010-09-07 6:32 UTC (permalink / raw)
To: openembedded-devel
2010/9/7 Graham Gower <graham.gower@gmail.com>:
> On 6 September 2010 21:49, Noor Ahsan <noor_ahsan@mentor.com> wrote:
>> * Remove do_stage ()
>> * Replace tabs with 8 spaces in do_configure
>
> I see that spaces and not tabs are the OE policy, but I can't lay my
> eyes on anything that says how many spaces are preferred. I see a lot
> of recipes and examples using 4 space indentation (and most others use
> a tab). Is this something that people care about?
>
> -Graham
>
> PS: Personally I'm a tab man, not a spaceman.
Afaik it is not defined.
There is http://wiki.openembedded.net/index.php/Styleguide
which only says "#
# Use spaces for indentation as developers tends to use different
amount of spaces per one tab. "
now we're just using a different amount of spaces :-)
(actually using different # of spaces for a tab is not that bad as
long as you stick to tabs only. That is why the linux kernel requires
indentig by tabs).
Frans (who also likes tabs, if only because it is the default in vi
with autoindent (and yeah, I know you can change that))
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libsdl-native: Convert to new style staging, remove do_stage
2010-09-07 6:32 ` Frans Meulenbroeks
@ 2010-09-07 6:32 ` Graeme Gregory
0 siblings, 0 replies; 6+ messages in thread
From: Graeme Gregory @ 2010-09-07 6:32 UTC (permalink / raw)
To: openembedded-devel
On 07/09/10 07:32, Frans Meulenbroeks wrote:
> 2010/9/7 Graham Gower <graham.gower@gmail.com>:
>> On 6 September 2010 21:49, Noor Ahsan <noor_ahsan@mentor.com> wrote:
>>> * Remove do_stage ()
>>> * Replace tabs with 8 spaces in do_configure
>> I see that spaces and not tabs are the OE policy, but I can't lay my
>> eyes on anything that says how many spaces are preferred. I see a lot
>> of recipes and examples using 4 space indentation (and most others use
>> a tab). Is this something that people care about?
>>
>> -Graham
>>
>> PS: Personally I'm a tab man, not a spaceman.
> Afaik it is not defined.
> There is http://wiki.openembedded.net/index.php/Styleguide
> which only says "#
> # Use spaces for indentation as developers tends to use different
> amount of spaces per one tab. "
> now we're just using a different amount of spaces :-)
>
> (actually using different # of spaces for a tab is not that bad as
> long as you stick to tabs only. That is why the linux kernel requires
> indentig by tabs).
>
> Frans (who also likes tabs, if only because it is the default in vi
> with autoindent (and yeah, I know you can change that))
>
Informally the policy has always been we dont care tabs or spaces as
long as its consistent within the same recipe.
Graeme
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-07 6:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-06 12:19 [PATCH] libsdl-native: Convert to new style staging, remove do_stage Noor Ahsan
2010-09-06 12:34 ` Frans Meulenbroeks
2010-09-06 12:38 ` Ahsan, Noor
2010-09-06 23:27 ` Graham Gower
2010-09-07 6:32 ` Frans Meulenbroeks
2010-09-07 6:32 ` Graeme Gregory
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.