From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [patch 1/2] qemu-kvm: use usptream eventfd code
Date: Tue, 07 Sep 2010 11:21:32 +0300 [thread overview]
Message-ID: <4C85F60C.3060700@redhat.com> (raw)
In-Reply-To: <20100906202301.291967128@amt.cnet>
On 09/06/2010 11:20 PM, Marcelo Tosatti wrote:
> Upstream code is equivalent.
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
> Index: qemu-kvm/cpus.c
> ===================================================================
> --- qemu-kvm.orig/cpus.c
> +++ qemu-kvm/cpus.c
> @@ -290,11 +290,6 @@ void qemu_notify_event(void)
> {
> CPUState *env = cpu_single_env;
>
> - if (kvm_enabled()) {
> - qemu_kvm_notify_work();
> - return;
> - }
> -
> qemu_event_increment ();
> if (env) {
> cpu_exit(env);
qemu_event_increment() is indeed equivalent, but what about the rest?
Are we guaranteed that cpu_single_env == NULL?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-09-07 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 20:20 [patch 0/2] qemu-kvm cleanups Marcelo Tosatti
2010-09-06 20:20 ` [patch 1/2] qemu-kvm: use usptream eventfd code Marcelo Tosatti
2010-09-07 8:21 ` Avi Kivity [this message]
2010-09-07 17:25 ` Marcelo Tosatti
2010-09-08 8:25 ` Avi Kivity
2010-09-06 20:20 ` [patch 2/2] qemu-kvm: drop posix-aio-compat.cs signalfd usage Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C85F60C.3060700@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.