From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa: fix cpu_is_pxa*() not expanded to zero when not configured
Date: Tue, 07 Sep 2010 13:35:24 +0400 [thread overview]
Message-ID: <4C86075C.30802@ru.mvista.com> (raw)
In-Reply-To: <AANLkTinqc=k3H0QL5PKNu6Je=qs=GBNAQ21nv5HkvGom@mail.gmail.com>
Hello.
On 07-09-2010 8:09, Eric Miao wrote:
> Could you give this a run?
> diff --git a/arch/arm/mach-pxa/include/mach/hardware.h
> b/arch/arm/mach-pxa/include/mach/hardware.h
> index 7f64d24..b036500 100644
> --- a/arch/arm/mach-pxa/include/mach/hardware.h
> +++ b/arch/arm/mach-pxa/include/mach/hardware.h
> @@ -264,23 +264,35 @@
> *<= 0x2 for pxa21x/pxa25x/pxa26x/pxa27x
> * == 0x3 for pxa300/pxa310/pxa320
> */
> +#if defined(CONFIG_PXA25x) || defined(CONFIG_PXA27x)
> #define __cpu_is_pxa2xx(id) \
> ({ \
> unsigned int _id = (id)>> 13& 0x7; \
> _id<= 0x2; \
> })
> +#else
> +#define __cpu_is_pxa2xx(id) (0)
Why enclose 0 in parens?
WBR, Sergei
next prev parent reply other threads:[~2010-09-07 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 4:09 [PATCH] pxa: fix cpu_is_pxa*() not expanded to zero when not configured Eric Miao
2010-09-07 4:13 ` Marek Vasut
2010-09-07 9:35 ` Sergei Shtylyov [this message]
2010-09-07 9:48 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C86075C.30802@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.