From: Bernhard Kohl <bernhard.kohl@nsn.com>
To: ext Christoph Hellwig <hch@lst.de>
Cc: kwolf@redhat.com, Alexander Graf <agraf@suse.de>,
Bernhard Kohl <bernhard.kohl@gmx.net>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices
Date: Tue, 07 Sep 2010 11:40:32 +0200 [thread overview]
Message-ID: <4C860890.2030301@nsn.com> (raw)
In-Reply-To: <20100907020448.GA1508@lst.de>
Am 07.09.2010 04:04, schrieb ext Christoph Hellwig:
> On Mon, Sep 06, 2010 at 05:39:00PM +0200, Alexander Graf wrote:
>
>> On 06.09.2010, at 17:06, Bernhard Kohl wrote:
>>
>>
>>> From: Bernhard Kohl<bernhard.kohl@gmx.net>
>>>
>>> Allow symbolic links which point to /dev/sgX devices.
>>>
>> Couldn't you send an SG_IO test ioctl over and see if it works? I really dislike the whole file name magic matching.
>>
> You could, but the result would not be what you expect, given that every
> /dev/sd* device and more in Linux support it.
>
> What we really need is to stop shoe-horning scsi pass through support
> into the block layer. Once we finally get our generic thread offload
> facilily there is no need for it anymore at all, scsi-generic can
> simplify offload the SG_IO ioctl and be done with it. I even have an
> old prototype for this, just waiting for the generic thread offload
> to get merged before resurrecting it.
>
Wouldn't it be OK to apply this patch in the meantime before we get
this complete new solution? I need to handle about 15 /dev/sg* disks
which are randomly numbered. With this patch I can use the udev
generated links in /dev/disk/by*, which makes life much easier.
next prev parent reply other threads:[~2010-09-07 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 15:06 [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic devices Bernhard Kohl
2010-09-06 15:39 ` Alexander Graf
2010-09-07 2:04 ` Christoph Hellwig
2010-09-07 9:40 ` Bernhard Kohl [this message]
2010-09-07 9:44 ` Alexander Graf
2010-09-07 9:47 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C860890.2030301@nsn.com \
--to=bernhard.kohl@nsn.com \
--cc=agraf@suse.de \
--cc=bernhard.kohl@gmx.net \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.