From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 1/3] cgroup : add clone_children control file Date: Tue, 07 Sep 2010 22:23:36 +0200 Message-ID: <4C869F48.9050603@free.fr> References: <1283585466-30265-1-git-send-email-daniel.lezcano@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Menage Cc: "Serge E. Hallyn" , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "Eric W. Biederman" List-Id: containers.vger.kernel.org On 09/07/2010 09:34 PM, Paul Menage wrote: > On Sat, Sep 4, 2010 at 12:31 AM, Daniel Lezcano wrote: > >> @@ -229,6 +229,7 @@ inline int cgroup_is_removed(const struct cgroup *cgrp) >> /* bits in struct cgroupfs_root flags field */ >> enum { >> ROOT_NOPREFIX, /* mounted subsystems have no named prefix */ >> + ROOT_CLONE_CHILDREN, /* mounted subsystems will inherit from parent */ >> }; >> > This bit is awkward - you're storing the original value of the > clone_children flag to report in the mount options, but this isn't > necessarily the current state. Might it be better to not store this > and just report the current value of the root cgroup's > CGRP_CLONE_CHILDREN flag? > Sure. Shall I do the same as the release agent mount option ? Thanks -- Daniel