From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 2/3] cgroup : make the mount options parsing more accurate Date: Tue, 07 Sep 2010 22:24:19 +0200 Message-ID: <4C869F73.7010804@free.fr> References: <1283585466-30265-1-git-send-email-daniel.lezcano@free.fr> <1283585466-30265-2-git-send-email-daniel.lezcano@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Menage Cc: "Serge E. Hallyn" , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "Eric W. Biederman" List-Id: containers.vger.kernel.org On 09/07/2010 09:38 PM, Paul Menage wrote: > On Sat, Sep 4, 2010 at 12:31 AM, Daniel Lezcano wrote: > >> The actual code does not detect 'all' with one subsystem name, which >> is IMHO mutually exclusive and when an option is specified even if it >> is not a subsystem name, we have to specify the 'all' option with the >> other option. >> eg: >> not detected : mount -t cgroup -o all,freezer cgroup /cgroup >> not flexible : mount -t cgroup -o noprefix,all cgroup /cgroup >> >> This patch fix this and makes the code a bit more clear by replacing >> 'else if' indentation by 'continue' blocks in the loop. >> > Can you fix this description to be clearer about the new behaviour of the code? > > Reviewed-by: Paul Menage > Sure no problem. Thanks for the review. -- Daniel