All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence
Date: Tue, 07 Sep 2010 23:14:28 +0200	[thread overview]
Message-ID: <4C86AB34.7090608@free.fr> (raw)
In-Reply-To: <20100907190016.754C2153798@gemini.denx.de>

Le 07/09/2010 21:00, Wolfgang Denk a ?crit :
> Dear Albert ARIBAUD,
>
> In message<4C867741.6060906@free.fr>  you wrote:
>>
>> I'm a bit lost at the logic of this last sentence. If errors are not
>> always represented as negative return values, and especially so in
>> U-boot, then what is the rationale for supporting a request for
>> specifically negative error return values, rather than positive, here?
>
> Even though ther eis lots of code that could need improvement, we
> should not take such bad examples, but rather try to apply standard
> techniques instead.
>
>> Not that I mind much -- as I said, ide_init() does not mind, and that's
>> my reference -- and I'll happily put negative error codes in V3, but I
>> like to understand why people want things.
>
> It's just a pretty common thing to do, and instead of doing the same
> thing in many different ways it makes some sense to use a standard
> way.

Understood.

Amicalement,
-- 
Albert.

  reply	other threads:[~2010-09-07 21:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-06 23:02 [U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence Albert Aribaud
2010-09-07  6:42 ` Prafulla Wadaskar
2010-09-07 11:23   ` Albert ARIBAUD
2010-09-07 13:32     ` Prafulla Wadaskar
2010-09-07 14:06       ` Wolfgang Denk
2010-09-07 17:32         ` Albert ARIBAUD
2010-09-07 19:00           ` Wolfgang Denk
2010-09-07 21:14             ` Albert ARIBAUD [this message]
2010-09-07  9:23 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C86AB34.7090608@free.fr \
    --to=albert.aribaud@free.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.