From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 1/3] cgroup : add clone_children control file Date: Wed, 08 Sep 2010 01:35:34 +0200 Message-ID: <4C86CC46.8010806@free.fr> References: <1283585466-30265-1-git-send-email-daniel.lezcano@free.fr> <4C869F48.9050603@free.fr> <4C86AAE1.2030608@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Menage Cc: "Serge E. Hallyn" , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "Eric W. Biederman" List-Id: containers.vger.kernel.org On 09/07/2010 11:22 PM, Paul Menage wrote: > On Tue, Sep 7, 2010 at 2:13 PM, Daniel Lezcano wrote: > >> The clone_children option behaves like the release-agent mount option no ? >> > Not quite, since it can be controlled on a per-cgroup basis. > > >> We can mount with a specific release agent and change it at runtime. IMHO it >> would be better to give a chance to the administrator to set its system with >> the mount option instead of force him to write post mount scripts. An >> alternative would be to set this cgroup option *only* via the mount option, >> but I am not sure it is good as it may be an unresolvable constraint for a >> system wanting to use the cgroups with and without this option (same kind of >> constraint we have with the ns_cgroup). >> >> I am favorable to keep the mount option and the ability to change it for >> another cgroup. >> > OK, lets mostly keep the current patch, but lose the flag stored at > mount-time and just report the mount option based on the current value > of the root cgroup's flag. > Ok, will resend a new version. Thanks for reviewing the patchset. -- Daniel