From: Trilok Soni <tsoni@codeaurora.org>
To: Sundar R IYER <sundar.iyer@stericsson.com>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
STEricsson_nomadik_linux <STEricsson_nomadik_linux@list.st.com>,
Linus WALLEIJ <linus.walleij@stericsson.com>
Subject: Re: [PATCH v3 1/1] input: add support for Nomadik SKE keypad controller
Date: Wed, 08 Sep 2010 18:28:04 +0530 [thread overview]
Message-ID: <4C87885C.70704@codeaurora.org> (raw)
In-Reply-To: <33A307AF30D7BF4F811B1568FE7A9B181C8565B5@EXDCVYMBSTM006.EQ1STM.local>
Hi Sundar,
>
> These registers are for the SKE Keypad - Scroll Key Encoder and Keypad modules. The
> scroll key encoder too shares them and hence in the header file.
Let's keep the only ones which are shared and not all. I am not sure about the scroll key
encoder driver location.
>
> Okay.
>
>> Can you please clarify why you need thread? Looking at the code, I don't think that
>> we have any need of creating thread. request_irq(...) should work just fine.
>
> Yes it can. I am seeing increasing tendency to migrate to threaded_irq from the legacy irq recently
> and hence the threaded request.
>
Use threaded_irq only when needed with different flags and not everywhere. In this case we don't
need threaded irq at all.
---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-09-08 12:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 12:48 [PATCH v3 1/1] input: add support for Nomadik SKE keypad controller Sundar Iyer
2010-09-06 15:07 ` Datta, Shubhrajyoti
2010-09-06 15:16 ` Sundar R IYER
2010-09-06 15:41 ` Datta, Shubhrajyoti
2010-09-06 15:43 ` Sundar R IYER
2010-09-07 6:37 ` Dmitry Torokhov
2010-09-07 6:49 ` Sundar R IYER
2010-09-07 14:01 ` Trilok Soni
2010-09-08 12:55 ` Sundar R IYER
2010-09-08 12:58 ` Trilok Soni [this message]
2010-09-08 14:19 ` Linus Walleij
2010-09-08 15:46 ` Dmitry Torokhov
2010-09-09 4:22 ` Sundar R IYER
2010-09-13 7:31 ` Sundar R IYER
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C87885C.70704@codeaurora.org \
--to=tsoni@codeaurora.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-input@vger.kernel.org \
--cc=sundar.iyer@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.