From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:27633 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755591Ab0IHNXs (ORCPT ); Wed, 8 Sep 2010 09:23:48 -0400 Message-ID: <4C878E60.3060000@codeaurora.org> Date: Wed, 08 Sep 2010 18:53:44 +0530 From: Trilok Soni MIME-Version: 1.0 Subject: Re: [PATCH v3] i2c: QUP based bus driver for Qualcomm MSM chipsets References: <1283907557-1874-1-git-send-email-kheitke@codeaurora.org> In-Reply-To: <1283907557-1874-1-git-send-email-kheitke@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Kenneth Heitke Cc: khali@linux-fr.org, ben-linux@fluff.org, srinidhi.kasagar@stericsson.com, linus.walleij@stericsson.com, linux-arm-msm@vger.kernel.org, arve@android.com, swetland@google.com, sdharia@codeaurora.com, David Brown , Daniel Walker , Bryan Huntsman , Russell King , Crane Cai , Samuel Ortiz , Ralf Baechle , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org On 9/8/2010 6:29 AM, Kenneth Heitke wrote: > This bus driver supports the QUP i2c hardware controller in the Qualcomm > MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general > purpose data path engine with input/output FIFOs and an embedded i2c > mini-core. The driver supports FIFO mode (for low bandwidth applications) > and block mode (interrupt generated for each block-size data transfer). > The driver currently does not support DMA transfers. > > Signed-off-by: Kenneth Heitke > --- > v3: uses DIV_ROUND_UP() as recommended by linus.walleij@stericsson.com > v2: incorporated feedback from the following people: > ben-linux@fluff.org > srinidhi.kasagar@stericsson.com > tsoni@codeaurora.org Looks good to me. Acked-by: Trilok Soni ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trilok Soni Subject: Re: [PATCH v3] i2c: QUP based bus driver for Qualcomm MSM chipsets Date: Wed, 08 Sep 2010 18:53:44 +0530 Message-ID: <4C878E60.3060000@codeaurora.org> References: <1283907557-1874-1-git-send-email-kheitke@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1283907557-1874-1-git-send-email-kheitke-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kenneth Heitke Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, srinidhi.kasagar-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org, linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arve-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, swetland-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, sdharia-sgV2jX0FEOLY0TyS/+Ba5Q@public.gmane.org, David Brown , Daniel Walker , Bryan Huntsman , Russell King , Crane Cai , Samuel Ortiz , Ralf Baechle , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On 9/8/2010 6:29 AM, Kenneth Heitke wrote: > This bus driver supports the QUP i2c hardware controller in the Qualcomm > MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general > purpose data path engine with input/output FIFOs and an embedded i2c > mini-core. The driver supports FIFO mode (for low bandwidth applications) > and block mode (interrupt generated for each block-size data transfer). > The driver currently does not support DMA transfers. > > Signed-off-by: Kenneth Heitke > --- > v3: uses DIV_ROUND_UP() as recommended by linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org > v2: incorporated feedback from the following people: > ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org > srinidhi.kasagar-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org > tsoni-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org Looks good to me. Acked-by: Trilok Soni ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: tsoni@codeaurora.org (Trilok Soni) Date: Wed, 08 Sep 2010 18:53:44 +0530 Subject: [PATCH v3] i2c: QUP based bus driver for Qualcomm MSM chipsets In-Reply-To: <1283907557-1874-1-git-send-email-kheitke@codeaurora.org> References: <1283907557-1874-1-git-send-email-kheitke@codeaurora.org> Message-ID: <4C878E60.3060000@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 9/8/2010 6:29 AM, Kenneth Heitke wrote: > This bus driver supports the QUP i2c hardware controller in the Qualcomm > MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general > purpose data path engine with input/output FIFOs and an embedded i2c > mini-core. The driver supports FIFO mode (for low bandwidth applications) > and block mode (interrupt generated for each block-size data transfer). > The driver currently does not support DMA transfers. > > Signed-off-by: Kenneth Heitke > --- > v3: uses DIV_ROUND_UP() as recommended by linus.walleij at stericsson.com > v2: incorporated feedback from the following people: > ben-linux at fluff.org > srinidhi.kasagar at stericsson.com > tsoni at codeaurora.org Looks good to me. Acked-by: Trilok Soni ---Trilok Soni -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.