From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: "David Härdeman" <david@hardeman.nu>
Cc: linux-media@vger.kernel.org, jarod@redhat.com
Subject: Re: [PATCH 1/5] rc-code: merge and rename ir-core
Date: Wed, 08 Sep 2010 10:42:10 -0300 [thread overview]
Message-ID: <4C8792B2.2010809@infradead.org> (raw)
In-Reply-To: <20100907215143.30935.71857.stgit@localhost.localdomain>
Em 07-09-2010 18:51, David Härdeman escreveu:
> This patch merges the files which makes up ir-core and renames the
> resulting module to rc-core. IMHO this makes it much easier to hack
> on the core module since all code is in one file.
>
> This also allows some simplification of ir-core-priv.h as fewer internal
> functions need to be exposed.
I'm not sure about this patch. Big files tend to be harder to maintain,
as it takes more time to find the right functions inside it. Also, IMO,
it makes sense to keep the raw-event code on a separate file.
Anyway, if we apply this patch right now, it will cause merge conflicts with
the input tree, due to the get/setkeycodebig patches, and with some other
patches that are pending merge/review. The better is to apply such patch
just after the release of 2.6.37-rc1, after having all those conflicts
solved.
Cheers,
Mauro
next prev parent reply other threads:[~2010-09-08 13:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 21:51 [PATCH 0/5] rc-core: ir-core to rc-core conversion (v2) David Härdeman
2010-09-07 21:51 ` [PATCH 1/5] rc-code: merge and rename ir-core David Härdeman
2010-09-08 13:42 ` Mauro Carvalho Chehab [this message]
2010-09-08 14:10 ` Jarod Wilson
2010-09-08 21:42 ` David Härdeman
2010-09-09 4:44 ` Jarod Wilson
2010-09-07 21:51 ` [PATCH 2/5] rc-core: remove remaining users of the ir-functions keyhandlers David Härdeman
2010-09-09 5:00 ` Jarod Wilson
2010-09-07 21:51 ` [PATCH 3/5] imon: split mouse events to a separate input dev David Härdeman
2010-09-07 21:51 ` [PATCH 4/5] rc-core: make struct rc_dev the primary interface for rc drivers David Härdeman
2010-09-09 4:41 ` Jarod Wilson
2010-09-07 21:52 ` [PATCH 5/5] rc-core: convert winbond-cir David Härdeman
-- strict thread matches above, loose matches on Subject: below --
2010-09-08 15:10 [PATCH 1/5] rc-code: merge and rename ir-core Andy Walls
2010-09-08 21:12 ` David Härdeman
2010-09-09 8:20 ` Maxim Levitsky
2010-09-02 20:29 [PATCH 0/5] rc-core: ir-core to rc-core conversion David Härdeman
2010-09-02 20:29 ` [PATCH 1/5] rc-code: merge and rename ir-core David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8792B2.2010809@infradead.org \
--to=mchehab@infradead.org \
--cc=david@hardeman.nu \
--cc=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.