Re: Patch to fix swapping of front and back porches when reading from modedb.c

[Tasslehoff Kjappfot <tasskjapp@gmail.com>]

  On 09/08/2010 03:38 PM, Russ Dill wrote:
> On Wed, Sep 8, 2010 at 6:39 AM, Tasslehoff Kjappfot<tasskjapp@gmail.com>  wrote:
>>
>> Hi list :-)
>>
>> I had trouble getting a standard 800x600@60Hz VGA signal to display
>> correctly on my monitors. Measuring the output showed that the front and
>> back porches were swapped both for hsync and vsync. After reading the source
>> I think I found the error in drivers/video/omap2/omapfb/omapfb-main.c. Patch
>> attached.
>>
>> http://www.xfree86.org/3.3.6/fbdev6.html shows the way it should be, but
>> todays code sets:
>>
>> hfp = left margin
>> hbp = right margin
>> vfp = upper margin
>> vbp = lower margin
>>
>> I tested a patched kernel with 800x600@60Hz on two different monitors and a
>> vga grabber, and it solved my issues.
> This looks good. Before this came up, I also thought that front porch
> meant left margin, and back porch meant margin, but margins are named
> in relation to pixel data, and porches are named in relation to sync
> pulses.
>
> You might want to add a Signed-off-by line
>
> Reviewed-by: Russ.Dill@gmail.com

Signed-off-by: tasskjapp@gmail.com