From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1OtMXn-0000XZ-Hw for mharc-grub-devel@gnu.org; Wed, 08 Sep 2010 11:26:39 -0400 Received: from [140.186.70.92] (port=51250 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtMXg-0000Vd-A7 for grub-devel@gnu.org; Wed, 08 Sep 2010 11:26:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OtMXc-0001uK-0C for grub-devel@gnu.org; Wed, 08 Sep 2010 11:26:32 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:57741) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OtMXb-0001uC-Rm for grub-devel@gnu.org; Wed, 08 Sep 2010 11:26:27 -0400 Received: by fxm3 with SMTP id 3so176655fxm.0 for ; Wed, 08 Sep 2010 08:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=2y+qvwd2dyMUJraLY7qsFGhDerhmwJowQw8HVRm6vVQ=; b=STke4fipEMaibFJU/rCrcv2bwqD5F2LzG6QBR0dhQlFVG/iDUOzcHGZbAS7gxbw3Fj d9QgEcijkbUhIzGmVKpY5YFjLlYLqOQf3lyX+cmFNCQn7R/WICpVqWyBIsnlWBgeWbgL 77bRf1BXhNvOKmkgXLv64vWbBZvVtYmblaz6c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=skNX0U0TYGPl/h0tc4ulnAFVgqB03B5ZQ/Ful+8V+x4JxkZISAYYR7huOXVQWxjdOO Atfu+2ZZLQs0tfyPKOEnbAm43mMC2OnPUkjq93LBK9x1cA+AcqsAK53rt+pu20nicMlp vcVy5vWm+ifpQqblMEGeAPKZIWUwlTyUUveaw= Received: by 10.223.107.143 with SMTP id b15mr88012fap.102.1283959586798; Wed, 08 Sep 2010 08:26:26 -0700 (PDT) Received: from debian.bg45.phnet (224-225.62-81.cust.bluewin.ch [81.62.225.224]) by mx.google.com with ESMTPS id b36sm99204faq.35.2010.09.08.08.26.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 08 Sep 2010 08:26:25 -0700 (PDT) Message-ID: <4C87AB1A.9060208@gmail.com> Date: Wed, 08 Sep 2010 17:26:18 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Icedove/3.0.6 MIME-Version: 1.0 To: grub-devel@gnu.org References: In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigD0A963238394120875B81D6D" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] MINIX file system version 3 support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2010 15:26:38 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD0A963238394120875B81D6D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/28/2010 05:25 AM, Fam Zheng wrote: > Hi, > > To support MINIX file system version 3, this patch adds a new module > named 'minix3'. It reuses most of the code in minix.mod, and handles > the latest MINIX file system version 3. > > The requested assignment information has also been sent to > assign@gnu.org . > Please, ensure that patches have correct mime type. It's annoying to have to save them separately just to view. struct grub_minix_inode inode; struct grub_minix2_inode inode2; +#ifdef GRUB_MOD_MINIX3 inode and inode2 shouldn't be present in minix3 structure. +static unsigned int blocksize; + All FS info must be in _data structure. Otherwise 2 simultaneously mounted filesystems will conflict. +#ifdef GRUB_MOD_MINIX3 + first_dbl_indir=3Dindir_capacity+7; + if (blk < first_dbl_indir) + { + blk -=3D 7; + indir =3D grub_get_indir (GRUB_MINIX_INODE_INDIR_ZONE (data), blk)= ; + return indir; + } +#else Where does 7 come from? It must be macroified. + if(ino=3D=3D0) return GRUB_ERR_BAD_ARGUMENT; must be 2 lines and return should be return grub_error (GRUB_ERR_BAD_FS, "incorrect inode"); +#define GRUB_MOD_MINIX3 +#include "minix.c" It should be MODE_MINIX3 I'm now splitting minix.mod into minix.mod nd minix2.mod, once I'm finished please adjust your patch --=20 > Best Regards! > Fam Zheng > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigD0A963238394120875B81D6D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAkyHqxoACgkQNak7dOguQgmKzQD+PyvadB0LQDWn8i5jzvw13tsS PotSNExbFIbtHQFY3DYBAI9CqXxJxFXWNLc3FndOgl+AZd6CFrH0U6pJpsCBQDZE =LcWu -----END PGP SIGNATURE----- --------------enigD0A963238394120875B81D6D--