From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19827 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198Ab0IHShQ (ORCPT ); Wed, 8 Sep 2010 14:37:16 -0400 Message-ID: <4C87D7DD.9080806@redhat.com> Date: Wed, 08 Sep 2010 15:37:17 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: "Matti J. Aaltonen" CC: linux-media@vger.kernel.org, hverkuil@xs4all.nl, eduardo.valentin@nokia.com Subject: Re: [PATCH v9 4/4] Documentation: v4l: Add hw_seek spacing and FM_RX class References: <1283168302-19111-1-git-send-email-matti.j.aaltonen@nokia.com> <1283168302-19111-2-git-send-email-matti.j.aaltonen@nokia.com> <1283168302-19111-3-git-send-email-matti.j.aaltonen@nokia.com> <1283168302-19111-4-git-send-email-matti.j.aaltonen@nokia.com> <1283168302-19111-5-git-send-email-matti.j.aaltonen@nokia.com> In-Reply-To: <1283168302-19111-5-git-send-email-matti.j.aaltonen@nokia.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-ID: Sender: Mauro Carvalho Chehab Em 30-08-2010 08:38, Matti J. Aaltonen escreveu: > Add a couple of words about the spacing field in the HW seek struct, > about the V4L2_CAP_RAW_RDS_ONLY capability flag and about the > new FM RX control class. Same comment as patch 1/4: FM bandwidth can already be defined via VIDIOC_[G|S]_TUNER. So, this patch is just creating a duplicated API for something already defined. > > Signed-off-by: Matti J. Aaltonen > --- > Documentation/DocBook/v4l/controls.xml | 71 ++++++++++++++++++++ > Documentation/DocBook/v4l/dev-rds.xml | 5 ++ > .../DocBook/v4l/vidioc-s-hw-freq-seek.xml | 10 ++- > 3 files changed, 84 insertions(+), 2 deletions(-) > > diff --git a/Documentation/DocBook/v4l/controls.xml b/Documentation/DocBook/v4l/controls.xml > index 8408caa..e9512eb 100644 > --- a/Documentation/DocBook/v4l/controls.xml > +++ b/Documentation/DocBook/v4l/controls.xml > @@ -2088,6 +2088,77 @@ manually or automatically if set to zero. Unit, range and step are driver-specif > For more details about RDS specification, refer to > document, from CENELEC. > > +
> + FM Tuner Control Reference > + > + The FM Tuner (FM_RX) class includes controls for common features of > +devices that are capable of receiving FM transmissions. Currently this class includes a parameter > +defining the FM radio band being used. > + > + > + FM_RX Control IDs > + > + > + > + > + > + > + > + > + > + > + ID > + Type > + Description > + > + > + > + > + > + V4L2_CID_FM_RX_CLASS  > + class > + The FM_RX class > +descriptor. Calling &VIDIOC-QUERYCTRL; for this control will return a > +description of this control class. > + > + > + V4L2_CID_FM_RX_BAND  > + integer > + > + Configures the FM radio > +frequency range being used. Currently there are three bands in use, see +url="http://en.wikipedia.org/wiki/FM_broadcasting">Wikipedia. > +Usually 87.5 to 108.0 MHz is used, or some portion thereof, with a few exceptions: > +In Japan, the band 76-90 MHz is used and in the former Soviet republics > +and some Eastern European countries, the older 65-74 MHz band, > +referred also to as the OIRT band, is still used. > + > +The enum  v4l2_fm_rx_band defines possible values for the FM band. They are: > + > + > + > + > + V4L2_FM_BAND_OTHER  > + Frequencies from 87.5 to 108.0 MHz > + > + > + V4L2_FM_BAND_JAPAN  > + from 65 to 74 MHz > + > + > + V4L2_FM_BAND_OIRT  > + from 65 to 74 MHz > + > + > + > + > + > + > + > + > +
> + > +
> > >