From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kyungmin.park@samsung.com,
ben-linux@fluff.org
Subject: Re: [PATCH 2/4] ARM: Samsung: s5p-fimc: fix dma coherent mask
Date: Thu, 09 Sep 2010 10:44:14 +0900 [thread overview]
Message-ID: <4C883BEE.2070503@samsung.com> (raw)
In-Reply-To: <000301cb4fb7$b4448530$1ccd8f90$%kim@samsung.com>
W dniu 2010-09-09 09:41, Kukjin Kim pisze:
> Marek Szyprowski wrote:
>>
>> FIMC driver uses DMA_coherent allocator, which requires proper dma mask
>> to be set.
>>
>> Signed-off-by: Marek Szyprowski<m.szyprowski@samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>> ---
>> arch/arm/plat-s5p/dev-fimc0.c | 2 ++
>> arch/arm/plat-s5p/dev-fimc1.c | 2 ++
>> arch/arm/plat-s5p/dev-fimc2.c | 2 ++
>> 3 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-s5p/dev-fimc0.c b/arch/arm/plat-s5p/dev-fimc0.c
>> index d3f1a9b..9f26096 100644
>> --- a/arch/arm/plat-s5p/dev-fimc0.c
>> +++ b/arch/arm/plat-s5p/dev-fimc0.c
>> @@ -33,4 +33,6 @@ struct platform_device s5p_device_fimc0 = {
>> .id = 0,
>> .num_resources = ARRAY_SIZE(s5p_fimc0_resource),
>> .resource = s5p_fimc0_resource,
>> + .dev.dma_mask =&s5p_device_fimc0.dev.coherent_dma_mask,
>> + .dev.coherent_dma_mask = 0xffffffffUL,
>
> Ok...but I prefer following style :-)
> Could you please re-submit your this patch?
OK, I will update the style and resubmit the patch.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
WARNING: multiple messages have this Message-ID (diff)
From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: Samsung: s5p-fimc: fix dma coherent mask
Date: Thu, 09 Sep 2010 10:44:14 +0900 [thread overview]
Message-ID: <4C883BEE.2070503@samsung.com> (raw)
In-Reply-To: <000301cb4fb7$b4448530$1ccd8f90$%kim@samsung.com>
W dniu 2010-09-09 09:41, Kukjin Kim pisze:
> Marek Szyprowski wrote:
>>
>> FIMC driver uses DMA_coherent allocator, which requires proper dma mask
>> to be set.
>>
>> Signed-off-by: Marek Szyprowski<m.szyprowski@samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>> ---
>> arch/arm/plat-s5p/dev-fimc0.c | 2 ++
>> arch/arm/plat-s5p/dev-fimc1.c | 2 ++
>> arch/arm/plat-s5p/dev-fimc2.c | 2 ++
>> 3 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-s5p/dev-fimc0.c b/arch/arm/plat-s5p/dev-fimc0.c
>> index d3f1a9b..9f26096 100644
>> --- a/arch/arm/plat-s5p/dev-fimc0.c
>> +++ b/arch/arm/plat-s5p/dev-fimc0.c
>> @@ -33,4 +33,6 @@ struct platform_device s5p_device_fimc0 = {
>> .id = 0,
>> .num_resources = ARRAY_SIZE(s5p_fimc0_resource),
>> .resource = s5p_fimc0_resource,
>> + .dev.dma_mask =&s5p_device_fimc0.dev.coherent_dma_mask,
>> + .dev.coherent_dma_mask = 0xffffffffUL,
>
> Ok...but I prefer following style :-)
> Could you please re-submit your this patch?
OK, I will update the style and resubmit the patch.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2010-09-09 1:44 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 3:50 [PATCH] Platform fixes for s5p-fimc Marek Szyprowski
2010-09-06 3:50 ` Marek Szyprowski
2010-09-06 3:50 ` [PATCH 1/4] ARM: S5PC110: add fimc clocks Marek Szyprowski
2010-09-06 3:50 ` Marek Szyprowski
2010-09-09 0:23 ` Kukjin Kim
2010-09-09 0:23 ` Kukjin Kim
2010-09-06 3:50 ` [PATCH 2/4] ARM: Samsung: s5p-fimc: fix dma coherent mask Marek Szyprowski
2010-09-06 3:50 ` Marek Szyprowski
2010-09-09 0:41 ` Kukjin Kim
2010-09-09 0:41 ` Kukjin Kim
2010-09-09 1:44 ` Marek Szyprowski [this message]
2010-09-09 1:44 ` Marek Szyprowski
2010-09-09 2:17 ` [PATCH v2] " Marek Szyprowski
2010-09-09 2:17 ` Marek Szyprowski
2010-09-09 11:20 ` Kukjin Kim
2010-09-09 11:20 ` Kukjin Kim
2010-09-14 9:27 ` Marek Szyprowski
2010-09-14 9:27 ` Marek Szyprowski
2010-09-15 23:49 ` Kukjin Kim
2010-09-15 23:49 ` Kukjin Kim
2010-09-06 3:50 ` [PATCH 3/4] ARM: S5PC110: add common FIMC setup code Marek Szyprowski
2010-09-06 3:50 ` Marek Szyprowski
2010-09-06 4:16 ` Marek Vasut
2010-09-06 4:16 ` Marek Vasut
2010-09-06 4:34 ` Marek Szyprowski
2010-09-06 4:34 ` Marek Szyprowski
2010-09-06 4:40 ` Marek Vasut
2010-09-06 4:40 ` Marek Vasut
2010-09-06 4:52 ` Jassi Brar
2010-09-06 4:52 ` Jassi Brar
2010-09-06 8:46 ` Marek Szyprowski
2010-09-06 8:46 ` Marek Szyprowski
2010-09-06 9:17 ` Jassi Brar
2010-09-06 9:17 ` Jassi Brar
2010-09-06 10:21 ` Marek Szyprowski
2010-09-06 10:21 ` Marek Szyprowski
2010-09-06 11:28 ` Jassi Brar
2010-09-06 11:28 ` Jassi Brar
2010-09-06 9:10 ` Marek Szyprowski
2010-09-06 9:10 ` Marek Szyprowski
2010-09-06 3:50 ` [PATCH 4/4] ARM: S5PC110: use common FIMC clock " Marek Szyprowski
2010-09-06 3:50 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C883BEE.2070503@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.