From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46604 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OtgIP-0005SX-Ir
	for Qemu-devel@nongnu.org; Thu, 09 Sep 2010 08:32:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OtgIL-0004cc-Jo
	for Qemu-devel@nongnu.org; Thu, 09 Sep 2010 08:32:05 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:35172)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OtgIL-0004cL-F6
	for Qemu-devel@nongnu.org; Thu, 09 Sep 2010 08:32:01 -0400
Received: by gya1 with SMTP id 1so667629gya.4
	for <Qemu-devel@nongnu.org>; Thu, 09 Sep 2010 05:32:00 -0700 (PDT)
Message-ID: <4C88D3BE.5060504@codemonkey.ws>
Date: Thu, 09 Sep 2010 07:31:58 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Commit 8b33d9ee (was not on list)
References: <4C88C674.5090802@redhat.com>
In-Reply-To: <4C88C674.5090802@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Qemu-devel@nongnu.org

On 09/09/2010 06:35 AM, Kevin Wolf wrote:
>> commit 8b33d9eeba91422ee2d73b6936ad57262d18cf5a
>> Author: Anthony Liguori<aliguori@us.ibm.com>
>> Date:   Wed Sep 8 17:09:15 2010 -0500
>>
>>      Revert "Make default invocation of block drivers safer (v3)"
>>
>>      This reverts commit 79368c81bf8cf93864d7afc88b81b05d8f0a2c90.
>>
>>      Conflicts:
>>
>>          block.c
>>
>>      I haven't been able to come up with a solution yet for the corruption caused by
>>      unaligned requests from the IDE disk so revert until a solution can be written.
>>
>>      Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>>      
> I posted a fix for it on Tuesday.
>    

It was a revert but yeah, I guess I should have posted first.

I don't think your fix is good enough.  I had the same thought but it's 
an unbounded memory allocation.

Regards,

Anthony Liguori

> Kevin
>
>