From: Sachin Sant <sachinp@in.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
linux-s390@vger.kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [-next Sept 9] S309 Build break (mm/percpu.c)
Date: Fri, 10 Sep 2010 11:39:33 +0530 [thread overview]
Message-ID: <4C89CB9D.6010005@in.ibm.com> (raw)
In-Reply-To: <4C88EE00.70004@kernel.org>
Tejun Heo wrote:
> Commit bbddff05 (percpu: use percpu allocator on UP too) incorrectly
> excluded pcpu_build_alloc_info() on SMP configurations which use
> generic setup_per_cpu_area() like s390. The config ifdefs are
> becoming confusing. Fix and clean it up by,
>
> * Move pcpu_build_alloc_info() right on top of its two users -
> pcpu_{embed|page}_first_chunk() which are already in CONFIG_SMP
> block.
>
> * Define BUILD_{EMBED|PAGE}_FIRST_CHUNK which indicate whether each
> first chunk function needs to be included and use them to control
> inclusion of the three functions to reduce confusion.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Sachin Sant <sachinp@in.ibm.com>
> ---
> Can you please test this patch?
>
Tested the patch against yesterday's next release(20100909). Works fine.
Thanks Tejun.
Regards
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
prev parent reply other threads:[~2010-09-10 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 12:35 [-next Sept 9] S309 Build break (mm/percpu.c) Sachin Sant
2010-09-09 14:24 ` Tejun Heo
2010-09-10 6:09 ` Sachin Sant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C89CB9D.6010005@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.