From: Clemens Ladisch <clemens@ladisch.de>
To: Daniel Mack <daniel@caiaq.de>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] ALSA: snd-usb-caiaq: set up internal sample pointer positions in trigger callback
Date: Fri, 10 Sep 2010 09:27:48 +0200 [thread overview]
Message-ID: <4C89DDF4.8030200@ladisch.de> (raw)
In-Reply-To: <1284090901-4533-2-git-send-email-daniel@caiaq.de>
Daniel Mack wrote:
> Calling prepare() on a stream which is already active
... would be a bug; snd_pcm_pre_prepare() in sound/core/pcm_native.c
should prevent this. Why do you feel the need for this patch?
> shouldn't touch the sample pointer positions. This code belongs into
> the trigger callback, so move it there.
The trigger callback should execute as fast as possible; any
initialization that isn't need to directly start the stream should go
into the prepare callback.
Regards,
Clemens
next prev parent reply other threads:[~2010-09-10 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 3:54 [PATCH 1/3] ALSA: snd-usb-caiaq: drop version number Daniel Mack
2010-09-10 3:55 ` [PATCH 2/3] ALSA: snd-usb-caiaq: set up internal sample pointer positions in trigger callback Daniel Mack
2010-09-10 7:27 ` Clemens Ladisch [this message]
2010-09-10 8:10 ` Daniel Mack
2010-09-10 3:55 ` [PATCH 3/3] ALSA: snd-usb-caiaq: Add support for Traktor Kontrol S4 Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C89DDF4.8030200@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@caiaq.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.