All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org, kwolf@redhat.com,
	lcapitulino@redhat.com
Subject: Re: [PATCH] KVM test: tests.cfg.sample: add params to qemu command line properly
Date: Fri, 10 Sep 2010 19:04:31 +0300	[thread overview]
Message-ID: <4C8A570F.6010909@redhat.com> (raw)
In-Reply-To: <1284134252-16976-1-git-send-email-lmr@redhat.com>

  On 09/10/2010 06:57 PM, Lucas Meneghel Rodrigues wrote:
> There's a small bug on the qemu sample testset for KVM autotest:
> We need to append -enable-kvm as extra params to the qemu command
> line, not replace all extra params. Small bug, renders the unattended
> install unusable for folks trying qemu instead of qemu-kvm.
>
>
> @@ -920,11 +920,15 @@ class Job(DBObject):
>                      WHERE afe_job_id = %s
>                      """ % self.id)
>
> -        t_begin, t_end = time_row[0]
> -        delta = t_end - t_begin
> -        minutes, seconds = divmod(delta.seconds, 60)
> -        hours, minutes = divmod(minutes, 60)
> -        stats['execution_time'] = "%02d:%02d:%02d" % (hours, minutes, seconds)
> +        if time_row:
> +            t_begin, t_end = time_row[0]
> +            delta = t_end - t_begin
> +            minutes, seconds = divmod(delta.seconds, 60)
> +            hours, minutes = divmod(minutes, 60)
> +            stats['execution_time'] = "%02d:%02d:%02d" % (hours, minutes,
> +                                                          seconds)
> +        else:
> +            stats['execution_time'] = "00:00:00"

Appears to be unrelated.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2010-09-10 16:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 15:57 [PATCH] KVM test: tests.cfg.sample: add params to qemu command line properly Lucas Meneghel Rodrigues
2010-09-10 16:04 ` Avi Kivity [this message]
2010-09-10 16:06 ` Lucas Meneghel Rodrigues
  -- strict thread matches above, loose matches on Subject: below --
2010-09-10 16:08 Lucas Meneghel Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8A570F.6010909@redhat.com \
    --to=avi@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lmr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.