From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47375 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ou7C5-0001Nf-7V for qemu-devel@nongnu.org; Fri, 10 Sep 2010 13:15:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ou7C3-0003Xs-Em for qemu-devel@nongnu.org; Fri, 10 Sep 2010 13:15:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35137) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ou7C3-0003Xj-4f for qemu-devel@nongnu.org; Fri, 10 Sep 2010 13:15:19 -0400 Message-ID: <4C8A67A2.1080300@redhat.com> Date: Fri, 10 Sep 2010 19:15:14 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1284127451-22092-1-git-send-email-Jes.Sorensen@redhat.com> <1284127451-22092-2-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/1] Avoid compiler error when building block/blkdebug.c with -Wtype-limits List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 09/10/10 19:05, Blue Swirl wrote: > On Fri, Sep 10, 2010 at 2:04 PM, wrote: >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> --- >> block/blkdebug.c | 7 ++++++- >> 1 files changed, 6 insertions(+), 1 deletions(-) >> >> diff --git a/block/blkdebug.c b/block/blkdebug.c >> index 2a63df9..17d796d 100644 >> --- a/block/blkdebug.c >> +++ b/block/blkdebug.c >> @@ -439,7 +439,12 @@ static void blkdebug_debug_event(BlockDriverState *bs, BlkDebugEvent event) >> struct BlkdebugRule *rule; >> BlkdebugVars old_vars = s->vars; >> >> - if (event < 0 || event >= BLKDBG_EVENT_MAX) { >> + /* >> + * enum is not guaranteed to be signed on all archs, so cast to >> + * int before the comparison against zero to avoid compiler >> + * warning when building with -Wtype-limits >> + */ >> + if ((int)event < 0 || event >= BLKDBG_EVENT_MAX) { > > I changed 'if' to 'assert' in my version because the check could only > fail due to an internal error: > http://lists.nongnu.org/archive/html/qemu-devel/2010-09/msg00239.html Sorry I missed your posting. I am happy with your version too, ACK from me. I did a pull before doing this patch and didn't see it, which is why I posted my version, but your patch does the trick nicely. Cheers, Jes