All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Kerrisk <mtk.manpages@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: eric.dumazet@gmail.com, jengelh@medozas.de, kaber@trash.net,
	netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
	linux-man@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: [PATCH] enable getsockopt() for IP_NODEFRAG
Date: Sat, 11 Sep 2010 08:26:56 +0200	[thread overview]
Message-ID: <4C8B2130.7030605@gmail.com> (raw)

Hello Jiri

While integrating your man-pages patch for IP_NODEFRAG, I noticed 
that this option is settable by setsockopt(), but not gettable by 
getsockopt(). I suppose this is not intended. The (untested, 
trivial) patch below adds getsockopt() support.

The patch is against 2.6.36-rc3.

Cheers,

Michael

PS I've just configured Thunderbird on this machine, hopefully the 
patch is not mangled. Please let me know if there are problems.

Signed-off-by: Michael kerrisk <mtk.manpages@gmail.com>

--- net/ipv4/ip_sockglue.c.orig	2010-09-11 07:25:58.000000000 +0200
+++ net/ipv4/ip_sockglue.c	2010-09-11 07:43:43.000000000 +0200
@@ -1129,6 +1129,9 @@ static int do_ip_getsockopt(struct sock
 	case IP_HDRINCL:
 		val = inet->hdrincl;
 		break;
+	case IP_NODEFRAG:
+		val = inet->nodefrag;
+		break;
 	case IP_MTU_DISCOVER:
 		val = inet->pmtudisc;
 		break;
-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Watch my Linux system programming book progress towards publication!
http://blog.man7.org/

             reply	other threads:[~2010-09-11  6:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-11  6:26 Michael Kerrisk [this message]
     [not found] ` <4C8B2130.7030605-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-09-12 21:52   ` [PATCH] enable getsockopt() for IP_NODEFRAG Jiri Olsa
     [not found]     ` <20100912215230.GA2091-Iosbtnj8/lepmqaOOeWOyQ@public.gmane.org>
2010-09-14  2:57       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8B2130.7030605@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jengelh@medozas.de \
    --cc=jolsa@redhat.com \
    --cc=kaber@trash.net \
    --cc=linux-man@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.