All of lore.kernel.org
 help / color / mirror / Atom feed
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MMCI: use _cansleep GPIO functions
Date: Sat, 11 Sep 2010 18:08:40 +0400	[thread overview]
Message-ID: <4C8B8D68.103@ru.mvista.com> (raw)
In-Reply-To: <AANLkTikT5Jg5dqfjMrNTxb57BaGmcuAqsqiC9e7_d0TW@mail.gmail.com>

Hello.

Linus Walleij wrote:

> From: Linus Walleij <linus.walleij@stericsson.com>
> Date: Sat, 11 Sep 2010 13:36:20 +0200
> Subject: [PATCH] MMCI: use _cansleep GPIO functions

> Currently the kernel is screaming about slowpath at me for the
> wp/cd callbacks. Swicth to the _cansleep variants so as to silence
> this.

> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
> ---
>  drivers/mmc/host/mmci.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)

> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index f0c7313..c5fbf19 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
[...]
>  static int mmci_get_cd(struct mmc_host *mmc)
> @@ -629,7 +629,8 @@ static int mmci_get_cd(struct mmc_host *mmc)
> 
>  		status = plat->status(mmc_dev(host->mmc));
>  	} else
> -		status = !!gpio_get_value(host->gpio_cd) ^ plat->cd_invert;
> +		status = !!gpio_get_value_cansleep(host->gpio_cd)
> +			^ plat->cd_invert;

    Should be no space between ^ and operand, no?

WBR, Sergei

  parent reply	other threads:[~2010-09-11 14:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-09 20:31 [PATCH] MMCI: use _cansleep GPIO functions Linus Walleij
2010-09-11  5:37 ` Rabin Vincent
2010-09-11 11:22   ` Linus Walleij
2010-09-11 11:31     ` Linus Walleij
2010-09-11 11:32     ` Russell King - ARM Linux
2010-09-11 11:39       ` Linus Walleij
2010-09-11 11:40         ` Russell King - ARM Linux
2010-09-11 14:08         ` Sergei Shtylyov [this message]
2010-09-11 14:11           ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8B8D68.103@ru.mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.