All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH 2/3] e1000: Intel 82571EB: Don't wait for MNG cycle on unmanaged chips
Date: Sun, 12 Sep 2010 21:18:13 -0700	[thread overview]
Message-ID: <4C8DA605.2050707@gmail.com> (raw)
In-Reply-To: <1283192693-7328-3-git-send-email-Kyle.D.Moffett@boeing.com>

  Hi Kyle,

On 8/30/2010 11:24 AM, Kyle Moffett wrote:
> The Intel 82571EB chipset can be used in an unmanaged configuration as a
> fast dual-port Gig-E controller.  Unfortunately a board consturcted that
> way would fail to correctly come up because the driver polls for the
> completion of a management cycle that will never occur.
>
> To resolve this problem, we disable the poll and error return on chips
> whose EEPROMS indicate no management.  As a protection against
> misconfigured chipsets, we still delay for the entire management poll
> timeout.
>
> Signed-off-by: Kyle Moffett<Kyle.D.Moffett@boeing.com>
> ---
> Jeff Kirsher<jeffrey.t.kirsher@intel.com>  has already accepted a similar
> patch to the Linux kernel into his e1000e patch queue.
>
>   drivers/net/e1000.c |    7 +++++++
>   1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c
> index 2825342..c9677b4 100644
> --- a/drivers/net/e1000.c
> +++ b/drivers/net/e1000.c
> @@ -4266,6 +4266,13 @@ e1000_get_phy_cfg_done(struct e1000_hw *hw)
>   	/* Fall Through */
>   	case e1000_82571:
>   	case e1000_82572:
> +		/* Don't bother polling the management regs if unmanaged */
> +		if (!e1000_check_mng_mode(hw)) {
> +			DEBUGOUT("Unmanaged chip... skipping MNG polling\n");
> +			mdelay(timeout);
> +			return 0;
> +		}
> +
>   		while (timeout) {
>   			if (E1000_READ_REG(hw, EEMNGCTL)&  cfg_mask)
>   				break;
Applied to net/next after fixing typo in prologue (see if you can find it)

regards,
Ben

  reply	other threads:[~2010-09-13  4:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30 18:24 [U-Boot] [RFC] Board support patches for the eXMeritus HWW-1U-1A devices Kyle Moffett
2010-08-30 18:24 ` [U-Boot] [RFC][PATCH 1/3] DDR2: Support new JEDEC DDR2 SPD 1.3 spec Kyle Moffett
2010-09-03  3:06   ` Peter Tyser
2010-09-03  5:10     ` Kyle Moffett
2010-08-30 18:24 ` [U-Boot] [RFC][PATCH 2/3] e1000: Intel 82571EB: Don't wait for MNG cycle on unmanaged chips Kyle Moffett
2010-09-13  4:18   ` Ben Warren [this message]
2010-09-13  4:24     ` Kyle Moffett
2010-09-13  4:28       ` Ben Warren
2010-08-30 18:24 ` [U-Boot] [RFC][PATCH 3/3] Add board support for the eXMeritus HWW-1U-1A devices Kyle Moffett
2010-09-03  4:00   ` Peter Tyser
2010-09-03  5:50     ` Kyle Moffett
2010-09-07 22:09       ` Peter Tyser
2010-09-07 22:50         ` [U-Boot] [RFC][PATCH 3/3] Add board support for the eXMeritusHWW-1U-1A devices Moffett, Kyle D
2010-09-08  3:43           ` Peter Tyser
2010-09-07 21:21     ` [U-Boot] [RFC][PATCH 3/3] Add board support for the eXMeritus HWW-1U-1A devices Moffett, Kyle D
2010-09-07 21:40       ` Peter Tyser
2010-09-07 21:59         ` Wolfgang Denk
2010-09-07 22:21         ` [U-Boot] [RFC][PATCH 3/3] Add board support for the eXMeritusHWW-1U-1A devices Moffett, Kyle D
  -- strict thread matches above, loose matches on Subject: below --
2010-08-13 16:27 [U-Boot] [RFC] Board support patches for the eXMeritus HWW-1U-1A devices Kyle Moffett
2010-08-13 16:27 ` [U-Boot] [RFC][PATCH 2/3] e1000: Intel 82571EB: Don't wait for MNG cycle on unmanaged chips Kyle Moffett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8DA605.2050707@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.