All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Lawnick <ml.lawnick@gmx.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v3] hwmon: lm75: Add __devinit and
Date: Mon, 13 Sep 2010 09:22:02 +0000	[thread overview]
Message-ID: <4C8DED3A.5080300@gmx.de> (raw)
In-Reply-To: <1284365862-20438-1-git-send-email-shubhrajyoti@ti.com>

Shubhrajyoti D said the following:
...

> -static int
> +static int __devinit
>  lm75_probe(struct i2c_client *client, const struct i2c_device_id *id)
Are you sure?
If I understand correctly, this function will be thrown away after
system/module init. But what's about devices that are added later?
I would expect them to crash on init...

-- 
KR
Michael

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2010-09-13  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13  8:29 [lm-sensors] [PATCH v3] hwmon: lm75: Add __devinit and __devexit Shubhrajyoti D
2010-09-13  9:22 ` Michael Lawnick [this message]
2010-09-13 10:52 ` [lm-sensors] [PATCH v3] hwmon: lm75: Add __devinit and Datta, Shubhrajyoti
2010-09-13 11:12 ` Michael Lawnick
2010-09-13 11:46 ` Datta, Shubhrajyoti
2010-09-13 12:18 ` Michael Lawnick
2010-09-13 14:49 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8DED3A.5080300@gmx.de \
    --to=ml.lawnick@gmx.de \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.