From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS Date: Mon, 13 Sep 2010 13:22:42 +0400 Message-ID: <4C8DED62.3080208@ru.mvista.com> References: <831bc9523fe04ce899bc78230990033fbe009431.1284357372.git.matt@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:46817 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683Ab0IMJYW (ORCPT ); Mon, 13 Sep 2010 05:24:22 -0400 In-Reply-To: <831bc9523fe04ce899bc78230990033fbe009431.1284357372.git.matt@console-pimps.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Matt Fleming Cc: Robert Richter , linux-arch@vger.kernel.org, Russell King , linux-sh@vger.kernel.org, Peter Zijlstra , Frederic Weisbecker , Will Deacon , Arnaldo Carvalho de Melo , Paul Mundt , Ingo Molnar , linux-arm-kernel@lists.infradead.org Hello. On 13-09-2010 10:07, Matt Fleming wrote: > Currently, oprofile support is only functional if CONFIG_HW_PERF_EVENTS > is set. If this symbol is not set, oprofile initialisation will fail at > runtime. Instead of allowing the oprofile code to build but fail at > runtime it seems less confusing to not allow the code to be built unless > hardware performance counter support is available. > Signed-off-by: Matt Fleming > --- > arch/arm/Kconfig | 2 +- > arch/arm/oprofile/common.c | 9 --------- > 2 files changed, 1 insertions(+), 10 deletions(-) > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index a7ed21f..d29075c 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -14,7 +14,7 @@ config ARM > select RTC_LIB > select SYS_SUPPORTS_APM_EMULATION > select GENERIC_ATOMIC64 if (!CPU_32v6K) > - select HAVE_OPROFILE if (HAVE_PERF_EVENTS) > + select HAVE_OPROFILE if (HW_PERF_EVENTS) Could remove useless parens while at it... WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 13 Sep 2010 09:22:42 +0000 Subject: Re: [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS Message-Id: <4C8DED62.3080208@ru.mvista.com> List-Id: References: <831bc9523fe04ce899bc78230990033fbe009431.1284357372.git.matt@console-pimps.org> In-Reply-To: <831bc9523fe04ce899bc78230990033fbe009431.1284357372.git.matt@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hello. On 13-09-2010 10:07, Matt Fleming wrote: > Currently, oprofile support is only functional if CONFIG_HW_PERF_EVENTS > is set. If this symbol is not set, oprofile initialisation will fail at > runtime. Instead of allowing the oprofile code to build but fail at > runtime it seems less confusing to not allow the code to be built unless > hardware performance counter support is available. > Signed-off-by: Matt Fleming > --- > arch/arm/Kconfig | 2 +- > arch/arm/oprofile/common.c | 9 --------- > 2 files changed, 1 insertions(+), 10 deletions(-) > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index a7ed21f..d29075c 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -14,7 +14,7 @@ config ARM > select RTC_LIB > select SYS_SUPPORTS_APM_EMULATION > select GENERIC_ATOMIC64 if (!CPU_32v6K) > - select HAVE_OPROFILE if (HAVE_PERF_EVENTS) > + select HAVE_OPROFILE if (HW_PERF_EVENTS) Could remove useless parens while at it... WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Mon, 13 Sep 2010 13:22:42 +0400 Subject: [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS In-Reply-To: <831bc9523fe04ce899bc78230990033fbe009431.1284357372.git.matt@console-pimps.org> References: <831bc9523fe04ce899bc78230990033fbe009431.1284357372.git.matt@console-pimps.org> Message-ID: <4C8DED62.3080208@ru.mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 13-09-2010 10:07, Matt Fleming wrote: > Currently, oprofile support is only functional if CONFIG_HW_PERF_EVENTS > is set. If this symbol is not set, oprofile initialisation will fail at > runtime. Instead of allowing the oprofile code to build but fail at > runtime it seems less confusing to not allow the code to be built unless > hardware performance counter support is available. > Signed-off-by: Matt Fleming > --- > arch/arm/Kconfig | 2 +- > arch/arm/oprofile/common.c | 9 --------- > 2 files changed, 1 insertions(+), 10 deletions(-) > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index a7ed21f..d29075c 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -14,7 +14,7 @@ config ARM > select RTC_LIB > select SYS_SUPPORTS_APM_EMULATION > select GENERIC_ATOMIC64 if (!CPU_32v6K) > - select HAVE_OPROFILE if (HAVE_PERF_EVENTS) > + select HAVE_OPROFILE if (HW_PERF_EVENTS) Could remove useless parens while at it... WBR, Sergei