From: Jens Axboe <jaxboe@fusionio.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] cciss: freeing uninitialized data on error path
Date: Mon, 13 Sep 2010 12:09:00 +0000 [thread overview]
Message-ID: <4C8E145C.4020204@fusionio.com> (raw)
In-Reply-To: <20100911233947.GC25351@bicker>
On 2010-09-12 01:39, Dan Carpenter wrote:
> The "h->scatter_list" is allocated inside a for loop. If any of those
> allocations fail, then the rest of the list is uninitialized data. When
> we free it we should start from the top and free backwards so that we
> don't call kfree() on uninitialized pointers.
>
> Also if the allocation for "h->scatter_list" fails then we would get an
> Oops here. I should have noticed this when I send: 4ee69851c "cciss:
> handle allocation failure." but I didn't. Sorry about that.
Thanks Dan, applied.
--
Jens Axboe
prev parent reply other threads:[~2010-09-13 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 23:39 [patch] cciss: freeing uninitialized data on error path Dan Carpenter
2010-09-13 12:09 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8E145C.4020204@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.