From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only if data is transfered over Date: Mon, 13 Sep 2010 16:27:25 +0400 Message-ID: <4C8E18AD.8000502@ru.mvista.com> References: <1283873014-32511-1-git-send-email-tom.leiming@gmail.com> <1283873014-32511-6-git-send-email-tom.leiming@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:51475 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754934Ab0IMM2N (ORCPT ); Mon, 13 Sep 2010 08:28:13 -0400 In-Reply-To: <1283873014-32511-6-git-send-email-tom.leiming@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: tom.leiming@gmail.com Cc: greg@kroah.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, David Brownell , Felipe Balbi , Anand Gadiyar , Mike Frysinger Hello. tom.leiming@gmail.com wrote: > From: Ming Lei > Complete the current request only if the data transfer is over. > Signed-off-by: Ming Lei > Cc: David Brownell > Cc: Felipe Balbi > Cc: Anand Gadiyar > Cc: Mike Frysinger > Cc: Sergei Shtylyov > --- > drivers/usb/musb/musb_gadget.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c > index f3ee04f..fa826f9 100644 > --- a/drivers/usb/musb/musb_gadget.c > +++ b/drivers/usb/musb/musb_gadget.c > @@ -501,14 +501,14 @@ void musb_g_tx(struct musb *musb, u8 epnum) > request->zero = 0; > } > > - /* ... or if not, then complete it. */ > - musb_g_giveback(musb_ep, request, 0); > - > - request = musb_ep->desc ? next_request(musb_ep) : NULL; > - if (!request) { > - DBG(4, "%s idle now\n", > - musb_ep->end_point.name); > - return; > + if (request->actual == request->length) { But why not modify the conditional above all that code, just excluding 'is_dma' from it. This conditional already includes (request->actual == request->length) check. Please recast this patch. > + musb_g_giveback(musb_ep, request, 0); > + request = musb_ep->desc ? next_request(musb_ep) : NULL; > + if (!request) { > + DBG(4, "%s idle now\n", > + musb_ep->end_point.name); > + return; > + } > } > } > WBR, Sergei