From: Mike Christie <michaelc@cs.wisc.edu>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Hannes Reinecke <hare@suse.de>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
James Bottomley <James.Bottomley@suse.de>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Boaz Harrosh <bharrosh@panasas.com>,
Richard Sharpe <realrichardsharpe@gmail.com>,
Vasu Dev <vasu.dev@linux.intel.com>,
Joe Eykholt <jeykholt@cisco.com>
Subject: Re: [PATCH 0/2] lio-target: Add support for libcrypto crc32c and crc32-intel offload
Date: Mon, 13 Sep 2010 15:35:01 -0500 [thread overview]
Message-ID: <4C8E8AF5.5080205@cs.wisc.edu> (raw)
In-Reply-To: <1284407432.8171.41.camel@haakon2.linux-iscsi.org>
On 09/13/2010 02:50 PM, Nicholas A. Bellinger wrote:
>> IE the in-kernel crc32c routines apparently weren't able to
>> calculate the checksum in an endianness-independent manner.
>> So a CRC calculated on a BE machine would fail to be validated by a
>> LE machine and vice versa.
>>
>> Has this been fixed / verified?
>>
>
>> From taking a look at crypto/crc32c.c it still appears AFAICT to not be
> big endian safe. I was planning to test this patch on some powerpc/ppc
> hardware with v2.6.36-rc4 in the next days, but it looks like
> lio-core-2.6.git will need a seperate crypto/crc32c.c patch to function
> properly on big endian arches.
>
There was this bug that was fixed a couple years ago:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ef19454bd437b2ba14c9cda1de85debd9f383484
since then I think we have not had problems.
next prev parent reply other threads:[~2010-09-13 20:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 10:31 [PATCH 0/2] lio-target: Add support for libcrypto crc32c and crc32-intel offload Nicholas A. Bellinger
2010-09-13 9:21 ` Hannes Reinecke
2010-09-13 9:21 ` Hannes Reinecke
2010-09-13 19:50 ` Nicholas A. Bellinger
2010-09-13 20:35 ` Mike Christie [this message]
2010-09-13 20:40 ` Nicholas A. Bellinger
2010-09-13 22:20 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8E8AF5.5080205@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jeykholt@cisco.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=realrichardsharpe@gmail.com \
--cc=vasu.dev@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.