All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Hellstrom <daniel@gaisler.com>
To: sparclinux@vger.kernel.org
Subject: SPARC32 SMP 2.6.36-rc3 build error
Date: Tue, 14 Sep 2010 13:30:27 +0000	[thread overview]
Message-ID: <4C8F78F3.7020408@gaisler.com> (raw)

Hi,

I have problems linking Linux SPARC32 when SMP is enabled:

  LD      vmlinux
  SYSMAP  System.map
  SYSMAP  .tmp_System.map
  BTFIX   arch/sparc/boot/btfix.S
  AS      arch/sparc/boot/btfix.o
  LD      arch/sparc/boot/image
net/built-in.o: In function `net_rps_action_and_irq_enable':
/home/daniel/linux/linux/linux-2.6/net/core/dev.c:3337: undefined 
reference to `__smp_call_function_single'
make[1]: *** [arch/sparc/boot/image] Error 1
make: *** [zImage] Error 2


It seems that __smp_call_function_single() is missing in smp_32.h for 
SPARC32, for SPARC64 the function is declared in linux/smp.h and 
kernel/smp.c by defining USE_GENERIC_SMP_HELPERS in arch/sparc/Kconfig.

__smp_call_function_single() was introduced in 
e77c8e83dd587f2616d7ff20d23a897891e6e20d:

+#ifdef CONFIG_SMP
+/*
+ * net_rps_action sends any pending IPI's for rps.  This is only called from
+ * softirq and interrupts must be enabled.
+ */
+static void net_rps_action(cpumask_t *mask)
+{
+       int cpu;
+
+       /* Send pending IPI's to kick RPS processing on remote cpus. */
+       for_each_cpu_mask_nr(cpu, *mask) {
+               struct softnet_data *queue = &per_cpu(softnet_data, cpu);
+               if (cpu_online(cpu))
+                       __smp_call_function_single(cpu, &queue->csd, 0);
+       }
+       cpus_clear(*mask);
+}
+#endif


Any ideas what I might have done wrong?

Thanks,
Daniel Hellstrom

             reply	other threads:[~2010-09-14 13:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-14 13:30 Daniel Hellstrom [this message]
2010-09-14 21:12 ` SPARC32 SMP 2.6.36-rc3 build error David Miller
2010-09-15  4:42 ` David Miller
2010-09-15  4:42   ` David Miller
2010-09-15  7:20   ` Daniel Hellstrom
2010-09-15  7:20     ` Daniel Hellstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8F78F3.7020408@gaisler.com \
    --to=daniel@gaisler.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.