All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Support T/t for guest memory sizes
Date: Tue, 14 Sep 2010 09:00:43 -0500	[thread overview]
Message-ID: <4C8F800B.2090304@codemonkey.ws> (raw)
In-Reply-To: <1284471474-24989-1-git-send-email-Jes.Sorensen@redhat.com>

On 09/14/2010 08:37 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>    

anthony@titi:~/git/qemu$ grep "case 'G': case 'g':" *.c
monitor.c:                    case 'G': case 'g':
vl.c:            case 'G': case 'g':
vl.c:                case 'G': case 'g':

So there's more locations to fixup.  But while you're touching this 
code, it probably makes sense to add a str_to_bytes() function to 
cutils.c to make sure we accept things consistently for the future.

Regards,

Anthony Liguori


> ---
>   vl.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 3f45aa9..0663f2f 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2176,6 +2176,9 @@ int main(int argc, char **argv, char **envp)
>                   case 'G': case 'g':
>                       value<<= 30;
>                       break;
> +                case 'T': case 't':
> +                    value<<= 40;
> +                    break;
>                   default:
>                       fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
>                       exit(1);
>    

  reply	other threads:[~2010-09-14 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-14 13:37 [Qemu-devel] [PATCH] Support T/t for guest memory sizes Jes.Sorensen
2010-09-14 14:00 ` Anthony Liguori [this message]
2010-09-14 14:41   ` [Qemu-devel] " Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8F800B.2090304@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=Jes.Sorensen@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.