From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58296 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvYSM-0007EX-QF
	for qemu-devel@nongnu.org; Tue, 14 Sep 2010 12:34:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OvYMg-0002wv-Jw
	for qemu-devel@nongnu.org; Tue, 14 Sep 2010 12:28:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22630)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OvYMg-0002wq-Bi
	for qemu-devel@nongnu.org; Tue, 14 Sep 2010 12:28:14 -0400
Message-ID: <4C8FA297.2020807@redhat.com>
Date: Tue, 14 Sep 2010 18:28:07 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] qcow2 performance plan
References: <4C8F7394.8060802@redhat.com>
	<4C8F7BE4.5010102@codemonkey.ws>	<4C8F9087.2050005@redhat.com>
	<4C8F92D9.2000908@codemonkey.ws>	<4C8F9920.7070908@redhat.com>
	<AANLkTimtONED4Spt-i1A4bHdAfivxo3MhuECk-NAHtk3@mail.gmail.com>
	<4C8F9FDE.8050004@codemonkey.ws>
In-Reply-To: <4C8F9FDE.8050004@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

  On 09/14/2010 06:16 PM, Anthony Liguori wrote:
>
> Right, it should only freeze if the L2 table needs to be allocated, 
> not if it only needs to be updated.  IOW,
>
> diff --git a/block/qed.c b/block/qed.c
> index 4c4e7a2..0357c03 100644
> --- a/block/qed.c
> +++ b/block/qed.c
> @@ -948,7 +948,7 @@ static void qed_aio_write_data(void *opaque, int ret,
>      }
>
>      /* Freeze this request if another allocating write is in progress */
> -    if (need_alloc) {
> +    if (ret == QED_CLUSTER_L1) {
>          if (acb != QSIMPLEQ_FIRST(&s->allocating_write_reqs)) {
>              QSIMPLEQ_INSERT_TAIL(&s->allocating_write_reqs, acb, next);
>          }
>
> It's being a bit more conservative than it needs to be.

Yes, I hit this too.  So without this patch, it does serialize all 
allocating writes?

If multiple requests need to update pointers in L2, will those updates 
generate one write per request, or just two writes (one write from the 
first request, another from all those that serialized after it)?

-- 
error compiling committee.c: too many arguments to function