From: Pekka Enberg <penberg@kernel.org>
To: Christoph Lameter <cl@linux.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 1/2] SLUB: Fix merged slab cache names
Date: Tue, 14 Sep 2010 20:49:03 +0300 [thread overview]
Message-ID: <4C8FB58F.8010706@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1009141244330.444@router.home>
On 14.9.2010 20.47, Christoph Lameter wrote:
> On Tue, 14 Sep 2010, Pekka Enberg wrote:
>
>>> Put this into mm/slub.c as slub only flag? What is the difference from
>>> refcount == 1?
>> I can put it in mm/slub.c but I was worried about someone reusing the bit for
>> something else.
> Allocate from the other end like __OBJECT_POISON.
I'll do that. Thanks!
>> Do you mean refcount == 2? You don't know during kmem cache release time if
>> someone was merged to the cache or not.
>>> Ok. Keeping the original name. Why dont we do strdup by default and always
>>> do a kfree(s->name) on close?
>>>
>> I tried that. It gets very nasty during bootstrap.
> Add it only to kmem_cache_create() not to kmem_cache_open. That is not
> used during bootstrap. The bootstrap caches do not matter since they are
> never freed
I tried that too. It doesn't work because we get merged to kmalloc
caches and can't do kfree() on them.
Pekka
next prev parent reply other threads:[~2010-09-14 17:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 17:06 [PATCH 1/2] SLUB: Fix merged slab cache names Pekka Enberg
2010-09-14 17:06 ` [PATCH 2/2] SLUB: Mark merged slab caches in /proc/slabinfo Pekka Enberg
2010-09-14 17:10 ` Pekka Enberg
2010-09-14 17:28 ` Christoph Lameter
2010-09-14 17:59 ` Pekka Enberg
2010-09-14 18:05 ` Linus Torvalds
2010-09-14 18:47 ` Pekka Enberg
2010-09-14 17:26 ` [PATCH 1/2] SLUB: Fix merged slab cache names Christoph Lameter
2010-09-14 17:36 ` Pekka Enberg
2010-09-14 17:47 ` Christoph Lameter
2010-09-14 17:49 ` Pekka Enberg [this message]
2010-09-14 17:59 ` Christoph Lameter
2010-09-14 18:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8FB58F.8010706@kernel.org \
--to=penberg@kernel.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.