Re: [PATCH] i2c-mv64xxx: use subsys_initcall for early initialization

[Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>]

Ben Dooks wrote:
> On Sun, Sep 12, 2010 at 11:35:29AM +0200, Mike Rapoport wrote:
>> Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>> ---
>>  drivers/i2c/busses/i2c-mv64xxx.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> We really should have an i2c_initcall, but it may be difficult to move
> everyone over to it. What would be lovely is some form of dependency
> based initialisation, but that's probably a way off...

Yeah, that would be nice...

> I'll consider this for the next merge window.

Thanks

>> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
>> index 1624206..6f3d084 100644
>> --- a/drivers/i2c/busses/i2c-mv64xxx.c
>> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
>> @@ -592,7 +592,7 @@ mv64xxx_i2c_exit(void)
>>  	platform_driver_unregister(&mv64xxx_i2c_driver);
>>  }
>>  
>> -module_init(mv64xxx_i2c_init);
>> +subsys_initcall(mv64xxx_i2c_init);
>>  module_exit(mv64xxx_i2c_exit);
>>  
>>  MODULE_AUTHOR("Mark A. Greer <mgreer-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>");
> 


-- 
Sincerely yours,
Mike.