From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49385 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvtVw-0003YU-QZ for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:03:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvtVm-00024V-Ve for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:03:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9328) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvtVm-00024I-PR for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:03:02 -0400 Message-ID: <4C90E065.7020605@redhat.com> Date: Wed, 15 Sep 2010 17:04:05 +0200 From: Michal Novotny MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] serial: Update parameters after load References: <4C8E2B60.1010909@redhat.com> <20100915135356.GA29442@edde.se.axis.com> <4C90DA98.2010807@redhat.com> <20100915144550.GC29442@edde.se.axis.com> In-Reply-To: <20100915144550.GC29442@edde.se.axis.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: "qemu-devel@nongnu.org" On 09/15/2010 04:45 PM, Edgar E. Iglesias wrote: > On Wed, Sep 15, 2010 at 04:39:20PM +0200, Michal Novotny wrote: > >> On 09/15/2010 03:53 PM, Edgar E. Iglesias wrote: >> >>> On Mon, Sep 13, 2010 at 03:47:12PM +0200, Michal Novotny wrote: >>> >>> >>>> Hi, >>>> >>>> this is the patch to update serial port parameters after guest is >>>> already loaded. >>>> >>>> >>> Hi >>> >>> This patch didn't apply: >>> >>> % git am -s ~/.maildir/minovotn/ >>> Applying: serial: Update parameters after load >>> error: patch failed: hw/serial.c:674 >>> error: hw/serial.c: patch does not apply >>> Patch failed at 0001 serial: Update parameters after load >>> When you have resolved this problem run "git am --resolved". >>> If you would prefer to skip this patch, instead run "git am --skip". >>> To restore the original branch and stop patching run "git am --abort" >>> >>> >>> >>>> Signed-off-by: Michal Novotny >>>> >>>> >>> ^^^^ >>> missing space >>> >>> >> Hi, thanks. Nevetheless should there be a space between name and e-mail >> address? I didn't know what's right so if there should be a space please >> tell me to take care of it next time. >> > Hi Michal, > > If you setup your git environment with your name and email, you can > pass the -s flag to commit or set the format.signoff config option > and git will generate the SoB line for you. > > Cheers > Ok, thanks. I'm already having it but I didn't know about the format.signoff option. Thanks, Michal -- Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat