Re: [PATCH] phonesim: simulate language notification in sim app

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

Hi Jeevaka,

On 09/14/2010 05:27 PM, Jeevaka Badrappan wrote:
> ---
>  src/qsimcommand.cpp    |   11 ++++++++
>  src/simapplication.cpp |   68 ++++++++++++++++++++++++++++++++++++++++++++++++
>  src/simapplication.h   |    2 +
>  3 files changed, 81 insertions(+), 0 deletions(-)
> 
> diff --git a/src/qsimcommand.cpp b/src/qsimcommand.cpp
> index 9a9a169..9746592 100644
> --- a/src/qsimcommand.cpp
> +++ b/src/qsimcommand.cpp
> @@ -3280,6 +3280,17 @@ QByteArray QSimCommand::toPdu( QSimCommand::ToPduOptions options ) const
>          }
>          break;
>  
> +        case LanguageNotification:
> +        {
> +            if ( qualifier & 0x01 ) {
> +                data += (char)0xAD;
> +                data += (char)0x02;
> +                data += (char)0x73;
> +                data += (char)0x65;
> +            }
> +        }
> +        break;
> +

I'd really prefer that this wasn't completely hard-coded.  Can we make
an enum of some sort, or even use a QString (null means no language
object included)

Regards,
-Denis