From: "H. Peter Anvin" <hpa@zytor.com>
To: ling.ma@intel.com
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] [X86] Fix potential issue on memmove
Date: Wed, 15 Sep 2010 12:08:33 -0700 [thread overview]
Message-ID: <4C9119B1.7020808@zytor.com> (raw)
In-Reply-To: <1284515426-7417-1-git-send-email-ling.ma@intel.com>
On 09/14/2010 06:50 PM, ling.ma@intel.com wrote:
> From: Ma Ling <ling.ma@intel.com>
>
> memmove allow source and destination address to be overlap,
> but no limitation for memcpy. So memmove use forward or
> backward copy mode to handle src > dest and dest > src cases respectively.
> However memcpy has not address overlap, it may use any copy mode
> theoretically. Our original memmove will call memcpy and assume
> it must use forward copy mode, otherwise the system will crash,
> it is potential issue. The patch based on tip/x86/mem avoids
> this assumption.
>
> Signed-off-by: Ma Ling <ling.ma@intel.com>
This patch is certainly not based on the current tip:x86/mem. Could you
check out the current tip:x86/mem (which has a previous patch of yours
in it) and submit an incremental patch with a description about what
updates the previous patch and why?
-hpa
prev parent reply other threads:[~2010-09-15 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 1:50 [PATCH V3] [X86] Fix potential issue on memmove ling.ma
2010-09-15 19:08 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9119B1.7020808@zytor.com \
--to=hpa@zytor.com \
--cc=ling.ma@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.