From: Pawel Osciak <pawel@osciak.com>
To: han jonghun <jonghun79.han@gmail.com>
Cc: linux-media@vger.kernel.org, kyungmin.park@samsung.com,
m.szyprowski@samsung.com, t.fujak@samsung.com
Subject: Re: [PATCH v1 7/7] v4l: videobuf2: add CMA allocator
Date: Wed, 15 Sep 2010 22:25:23 +0200 [thread overview]
Message-ID: <4C912BB3.90107@osciak.com> (raw)
In-Reply-To: <AANLkTi=QYNNLqAYZcwECpa8Fxmpxt05i_0M_v+wk=+PJ@mail.gmail.com>
Hello,
On 09/15/2010 10:55 AM, han jonghun wrote:
> Hello,
>
> In vb2_cma_put if buf->refcount is 0, cma_free is called.
> But vb2_cma_put is usually called from munmap.
> In my opinion cma_free should be called from VIDIOC_REQBUFS(0) not munmap.
>
cma_free has to be called from both, since we do not always call
VIDIOC_REQBUFS(0) after finishing. If an application just closes
the file descriptor (or even dies), we need a way to clean up the
memory.
--
Best regards,
Pawel Osciak
next prev parent reply other threads:[~2010-09-15 20:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 9:19 [PATCH/RFC v1 0/7] Videobuf2 framework Pawel Osciak
2010-09-09 9:19 ` [PATCH v1 1/7] v4l: add videobuf2 Video for Linux 2 driver framework Pawel Osciak
2010-09-09 17:29 ` Mauro Carvalho Chehab
2010-09-15 20:16 ` Pawel Osciak
2010-09-25 14:27 ` Hans Verkuil
2010-09-29 23:40 ` Pawel Osciak
2010-09-09 9:19 ` [PATCH v1 2/7] v4l: videobuf2: add generic memory handling routines Pawel Osciak
2010-09-09 17:34 ` Mauro Carvalho Chehab
2010-09-09 9:19 ` [PATCH v1 3/7] v4l: mem2mem: port to videobuf2 Pawel Osciak
2010-09-09 9:19 ` [PATCH v1 4/7] v4l: videobuf2: add vmalloc allocator Pawel Osciak
2010-09-09 9:19 ` [PATCH v1 5/7] v4l: videobuf2: add DMA coherent allocator Pawel Osciak
2010-09-09 9:19 ` [PATCH v1 6/7] v4l: vivi: port to videobuf2 Pawel Osciak
2010-09-09 9:19 ` [PATCH v1 7/7] v4l: videobuf2: add CMA allocator Pawel Osciak
2010-09-15 8:55 ` han jonghun
2010-09-15 20:25 ` Pawel Osciak [this message]
2010-09-09 9:26 ` [PATCH/RFC v1 0/7] Videobuf2 framework Pawel Osciak
2010-09-09 17:53 ` Mauro Carvalho Chehab
2010-09-10 3:20 ` Pawel Osciak
2010-09-10 4:27 ` Mauro Carvalho Chehab
2010-09-10 7:38 ` Marek Szyprowski
2010-09-10 8:22 ` Hans Verkuil
2010-09-10 8:26 ` Devin Heitmueller
2010-09-10 13:50 ` Andy Walls
2010-09-10 12:15 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C912BB3.90107@osciak.com \
--to=pawel@osciak.com \
--cc=jonghun79.han@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=t.fujak@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.