From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522Ab0IPJKO (ORCPT ); Thu, 16 Sep 2010 05:10:14 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:52807 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826Ab0IPJKM (ORCPT ); Thu, 16 Sep 2010 05:10:12 -0400 X-Auth-Info: ddEjgzXO+N/M8RhGyjYzJToLn62gsVEvHgrGAZzGDOk= Message-ID: <4C91DF20.7040807@grandegger.com> Date: Thu, 16 Sep 2010 11:10:56 +0200 From: Wolfgang Grandegger User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 MIME-Version: 1.0 To: Masayuki Ohtake CC: Marc Kleine-Budde , arjan@linux.intel.com, Tomoya MORINAGA , yong.y.wang@intel.com, gregkh@suse.de, qi.wang@intel.com, andrew.chih.howe.khor@intel.com, meego-dev@meego.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, socketcan-core@lists.berlios.de, Samuel Ortiz , Barry Song <21cnbao@gmail.com>, Christian Pellegrin , Wolfram Sang , "David S. Miller" Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35 References: <4C8E1773.9090000@dsn.okisemi.com> <4C8E3FDE.2000002@pengutronix.de> <002601cb557c$69292180$66f8800a@maildom.okisemi.com> In-Reply-To: <002601cb557c$69292180$66f8800a@maildom.okisemi.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/16/2010 10:51 AM, Masayuki Ohtake wrote: > Hi Marc, > >> - Please remove rx-filter handling from the driver completely, simply >> receive every can frame > > This rx-filter function is for Topcliff's CAN HW function. > This function is important. > Could you tell us the reason why should we remove filter function ? We do not (yet) support the filtering capability of the CAN controller hardware. Therefore please configure the hardware filter to accept *any* CAN message like all other drivers do, e.g.: http://lxr.linux.no/#linux+v2.6.35.4/drivers/net/can/sja1000/sja1000.c#L249 Wolfgang. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35 Date: Thu, 16 Sep 2010 11:10:56 +0200 Message-ID: <4C91DF20.7040807@grandegger.com> References: <4C8E1773.9090000@dsn.okisemi.com> <4C8E3FDE.2000002@pengutronix.de> <002601cb557c$69292180$66f8800a@maildom.okisemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, Marc Kleine-Budde , Tomoya MORINAGA , meego-dev-WXzIur8shnEAvxtiuMwx3w@public.gmane.org, arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, "David S. Miller" , Christian Pellegrin , Samuel Ortiz To: Masayuki Ohtake Return-path: In-Reply-To: <002601cb557c$69292180$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On 09/16/2010 10:51 AM, Masayuki Ohtake wrote: > Hi Marc, > >> - Please remove rx-filter handling from the driver completely, simply >> receive every can frame > > This rx-filter function is for Topcliff's CAN HW function. > This function is important. > Could you tell us the reason why should we remove filter function ? We do not (yet) support the filtering capability of the CAN controller hardware. Therefore please configure the hardware filter to accept *any* CAN message like all other drivers do, e.g.: http://lxr.linux.no/#linux+v2.6.35.4/drivers/net/can/sja1000/sja1000.c#L249 Wolfgang.