From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs Date: Thu, 16 Sep 2010 12:10:06 -0500 Message-ID: <4C924F6E.6040804@ti.com> References: <1284587799-9637-1-git-send-email-khilman@deeprootsystems.com> <1284587799-9637-2-git-send-email-khilman@deeprootsystems.com> <87sk19eneu.fsf@deeprootsystems.com> <4C92386F.2070600@ti.com> <87vd65bsfs.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:41652 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139Ab0IPRKK (ORCPT ); Thu, 16 Sep 2010 13:10:10 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Linus Walleij Cc: Kevin Hilman , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Linus Walleij had written, on 09/16/2010 12:07 PM, the following: > 2010/9/16 Kevin Hilman : > >> lib/opp/* seems more appropriate to me with the header at >> include/linux/opp.h as Linus suggested. > > I second this. I would love to see the generic OPP stuff in > lib/opp/* so we put it in the right place from the beginning and > don't have to painfully refactor everything later (clk.h > especially comes to mind.) cool.. digging a bit deeper into lib directory, I propose the following: lib/opp.c include/linux/opp.h any soc specific data (for registration etc) -> goes to arch//mach-/oppdata_xyz.c or what ever they choose the intent being lib/ is no place to put mach or arch specific data definitions.. it is just noise.. if folks are ok with this, will post a new rev soonish.. -- Regards, Nishanth Menon From mboxrd@z Thu Jan 1 00:00:00 1970 From: nm@ti.com (Nishanth Menon) Date: Thu, 16 Sep 2010 12:10:06 -0500 Subject: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs In-Reply-To: References: <1284587799-9637-1-git-send-email-khilman@deeprootsystems.com> <1284587799-9637-2-git-send-email-khilman@deeprootsystems.com> <87sk19eneu.fsf@deeprootsystems.com> <4C92386F.2070600@ti.com> <87vd65bsfs.fsf@deeprootsystems.com> Message-ID: <4C924F6E.6040804@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Linus Walleij had written, on 09/16/2010 12:07 PM, the following: > 2010/9/16 Kevin Hilman : > >> lib/opp/* seems more appropriate to me with the header at >> include/linux/opp.h as Linus suggested. > > I second this. I would love to see the generic OPP stuff in > lib/opp/* so we put it in the right place from the beginning and > don't have to painfully refactor everything later (clk.h > especially comes to mind.) cool.. digging a bit deeper into lib directory, I propose the following: lib/opp.c include/linux/opp.h any soc specific data (for registration etc) -> goes to arch//mach-/oppdata_xyz.c or what ever they choose the intent being lib/ is no place to put mach or arch specific data definitions.. it is just noise.. if folks are ok with this, will post a new rev soonish.. -- Regards, Nishanth Menon