From: Patrick McHardy <kaber@trash.net>
To: paulmck@linux.vnet.ibm.com
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] netfilter: fix a race in nf_ct_ext_create()
Date: Thu, 16 Sep 2010 20:00:04 +0200 [thread overview]
Message-ID: <4C925B24.8020900@trash.net> (raw)
In-Reply-To: <20100831155137.GE2421@linux.vnet.ibm.com>
On 31.08.2010 17:51, Paul E. McKenney wrote:
> On Tue, Aug 31, 2010 at 05:48:02PM +0200, Eric Dumazet wrote:
>> > As soon as rcu_read_unlock() is called, there is no guarantee current
>> > thread can safely derefence t pointer, rcu protected.
>> >
>> > Fix is to copy t->alloc_size in a temporary variable.
> Yow!!! Good catch!!!
>
> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
>> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2010-09-16 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 15:48 [PATCH] netfilter: fix a race in nf_ct_ext_create() Eric Dumazet
2010-08-31 15:51 ` Paul E. McKenney
2010-09-16 18:00 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C925B24.8020900@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.