From: Kevin Wolf <kwolf@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] qcow2: Move sync out of update_refcount
Date: Fri, 17 Sep 2010 19:19:21 +0200 [thread overview]
Message-ID: <4C93A319.5000900@redhat.com> (raw)
In-Reply-To: <4C93A01F.40706@codemonkey.ws>
Am 17.09.2010 19:06, schrieb Anthony Liguori:
> On 09/17/2010 11:18 AM, Kevin Wolf wrote:
>> Note that the flush is omitted intentionally in qcow2_free_clusters. If
>> anything, we can leak clusters here if we lose the writes.
>>
>> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
>>
>
> Cluster leaking gets picked up by bdrv_check though, right?
>
> I think I've convinced myself that leaking clusters is not an acceptable
> behavior from a security perspective but as long as it's detectable via
> bdrv_check, qcow2 could implement an online check to address it.
Leaking clusters on crashes is unavoidable. But yes, qemu-img check does
detect this.
Kevin
next prev parent reply other threads:[~2010-09-17 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 16:18 [Qemu-devel] [PATCH 0/4] qcow2: Save another common flush Kevin Wolf
2010-09-17 16:18 ` [Qemu-devel] [PATCH 1/4] qcow2: Move sync out of write_refcount_block_entries Kevin Wolf
2010-09-17 16:18 ` [Qemu-devel] [PATCH 2/4] qcow2: Move sync out of update_refcount Kevin Wolf
2010-09-17 17:06 ` Anthony Liguori
2010-09-17 17:19 ` Kevin Wolf [this message]
2010-09-17 16:18 ` [Qemu-devel] [PATCH 3/4] qcow2: Move sync out of qcow2_alloc_clusters Kevin Wolf
2010-09-17 16:18 ` [Qemu-devel] [PATCH 4/4] qcow2: Get rid of additional sync on COW Kevin Wolf
2010-09-17 17:05 ` [Qemu-devel] [PATCH 0/4] qcow2: Save another common flush Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C93A319.5000900@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.