diff for duplicates of <4C9604BF.1090809@bfs.de> diff --git a/a/1.txt b/N1/1.txt index d63d789..ddf147a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -36,14 +36,14 @@ Nils Radtke schrieb: > /* Tell the MSD to open */ > - if (wlandev->open != NULL) { > - result = wlandev->open(wlandev); -> - if (result = 0) { +> - if (result == 0) { > - netif_start_queue(wlandev->netdev); > - wlandev->state = WLAN_DEVICE_OPEN; > - } > - } else { > - result = -EAGAIN; -> + if (wlandev->open = NULL) { -> + printk(KERN_ERR "Sorry, got wlandev->open = NULL.\n"); +> + if (wlandev->open == NULL) { +> + printk(KERN_ERR "Sorry, got wlandev->open == NULL.\n"); > + ret = -EAGAIN; > + goto end; > } @@ -77,8 +77,8 @@ unwinding is always good :) > > - if (wlandev->close != NULL) > - result = wlandev->close(wlandev); -> + if (wlandev->close = NULL) { -> + printk(KERN_ERR "Sorry, got wlandev->close = NULL.\n"); +> + if (wlandev->close == NULL) { +> + printk(KERN_ERR "Sorry, got wlandev->close == NULL.\n"); > + ret = -EFAULT; /* FIXME: nr: correct return code? */ > + goto end; > + } @@ -100,7 +100,7 @@ unwinding is always good :) but i wonder if the the test for wlandev->open in X_close() is needed can wlandev->close vanish between open() and stop() ? -I am wondering who to use the error message "Sorry, got wlandev->open = NULL" +I am wondering who to use the error message "Sorry, got wlandev->open == NULL" is true but what help ? Give the reader a change and add __func__ to figure out what hit him. diff --git a/a/content_digest b/N1/content_digest index 936bf4f..dab0026 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01284834652-26171-1-git-send-email-lkml@Think-Future.com\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [PATCH] Staging: wlan-ng: p80211netdev.c cleanup\0" - "Date\0Sun, 19 Sep 2010 12:40:31 +0000\0" + "Date\0Sun, 19 Sep 2010 14:40:31 +0200\0" "To\0Nils Radtke <lkml@think-future.com>\0" "Cc\0gregkh@suse.de" kernel-janitors@vger.kernel.org @@ -47,14 +47,14 @@ "> \t/* Tell the MSD to open */\n" "> -\tif (wlandev->open != NULL) {\n" "> -\t\tresult = wlandev->open(wlandev);\n" - "> -\t\tif (result = 0) {\n" + "> -\t\tif (result == 0) {\n" "> -\t\t\tnetif_start_queue(wlandev->netdev);\n" "> -\t\t\twlandev->state = WLAN_DEVICE_OPEN;\n" "> -\t\t}\n" "> -\t} else {\n" "> -\t\tresult = -EAGAIN;\n" - "> +\tif (wlandev->open = NULL) {\n" - "> +\t\tprintk(KERN_ERR \"Sorry, got wlandev->open = NULL.\\n\");\n" + "> +\tif (wlandev->open == NULL) {\n" + "> +\t\tprintk(KERN_ERR \"Sorry, got wlandev->open == NULL.\\n\");\n" "> +\t\tret = -EAGAIN;\n" "> +\t\tgoto end;\n" "> \t}\n" @@ -88,8 +88,8 @@ "> \n" "> -\tif (wlandev->close != NULL)\n" "> -\t\tresult = wlandev->close(wlandev);\n" - "> +\tif (wlandev->close = NULL) {\n" - "> +\t\tprintk(KERN_ERR \"Sorry, got wlandev->close = NULL.\\n\");\n" + "> +\tif (wlandev->close == NULL) {\n" + "> +\t\tprintk(KERN_ERR \"Sorry, got wlandev->close == NULL.\\n\");\n" "> +\t\tret = -EFAULT; /* FIXME: nr: correct return code? */\n" "> +\t\tgoto end;\n" "> +\t}\n" @@ -111,7 +111,7 @@ "but i wonder if the the test for wlandev->open in X_close() is needed\n" "can wlandev->close vanish between open() and stop() ?\n" "\n" - "I am wondering who to use the error message \"Sorry, got wlandev->open = NULL\"\n" + "I am wondering who to use the error message \"Sorry, got wlandev->open == NULL\"\n" "is true but what help ? Give the reader a change and add __func__ to figure out\n" "what hit him.\n" "\n" @@ -130,4 +130,4 @@ "> \n" > /*---------------------------------------------------------------- -aad9997a26eea1308d63fb1858e429a24b0c47f687fc59d9ef552b1addc13036 +3b883ee52960faddbb774e7cda065b7dd3bc145a61f0e85e0a8af29ec8ff47ce
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.